From 9adf90c68bca35f095aab4b6b4875d979864d592 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 4 Aug 2012 10:41:39 +0300 Subject: [PATCH] [PATCH v2 1/7] build: drop the -Wswitch-enum warning --- d4/27c086d7e837cd228901a4ef48f00edbbdecd1 | 103 ++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 d4/27c086d7e837cd228901a4ef48f00edbbdecd1 diff --git a/d4/27c086d7e837cd228901a4ef48f00edbbdecd1 b/d4/27c086d7e837cd228901a4ef48f00edbbdecd1 new file mode 100644 index 000000000..901dce912 --- /dev/null +++ b/d4/27c086d7e837cd228901a4ef48f00edbbdecd1 @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 4378C431FB6 + for ; Sat, 4 Aug 2012 00:41:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 7XV-OToz3GbY for ; + Sat, 4 Aug 2012 00:41:53 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8412D431FAF + for ; Sat, 4 Aug 2012 00:41:53 -0700 (PDT) +Received: by mail-lpp01m010-f53.google.com with SMTP id u2so844636lag.26 + for ; Sat, 04 Aug 2012 00:41:53 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references + :in-reply-to:references:x-gm-message-state; + bh=Lkr/U+DfYLJmMelD/8ON3yzhjTz3TnHlY29/2rDe5jY=; + b=JvABoafzujdVoXJ10M3aOLrKQ4bSBF8zjc05mgG+Wi5qER7c22oDB11sginV2SzgCd + TjTs8uVny7cqpH/KGfj+VuJjd7bHDegIoO603AA0Ro7ru435gXrBgDT8TGRjMILgcEgy + Mt4XXnDYZ/vhRKQ55dKOG5EjRA/HhU8dJED1vDYpsz02E6MBTgKXAGD+U44bi+tvWW1h + KVqVPh/Mr7fcMr8W1brYQL2o6iGJXgjZ74LMAk1LgpIO0SiGD26wYjF6/9fVBHPYoNWU + NC4V6etiNBqRX/oSpkXagSBhQPz2MpbsjhE5C1ia7hJamuzKX/BCPsBWTAkG/afjFNma + jAOw== +Received: by 10.152.135.200 with SMTP id pu8mr4000149lab.8.1344066113002; + Sat, 04 Aug 2012 00:41:53 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id fd1sm2438311lbb.7.2012.08.04.00.41.51 + (version=SSLv3 cipher=OTHER); Sat, 04 Aug 2012 00:41:52 -0700 (PDT) +From: Jani Nikula +To: notmuch@notmuchmail.org +Subject: [PATCH v2 1/7] build: drop the -Wswitch-enum warning +Date: Sat, 4 Aug 2012 10:41:39 +0300 +Message-Id: + <1045e9574656c8a3389cfee1057c3a3e2cf0b555.1344065790.git.jani@nikula.org> +X-Mailer: git-send-email 1.7.9.5 +In-Reply-To: +References: +In-Reply-To: +References: +X-Gm-Message-State: + ALoCoQlABoyYuAmcSuPrEo446QBORVhn1Yp9Eau0ARhym60F5rztDYLtA4lVKmGehH+L1I6t5+za +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 04 Aug 2012 07:41:54 -0000 + +-Wswitch-enum is a bit awkward if a switch statement is intended to +handle just some of the named codes of an enumeration especially, and +leave the rest to the default label. + +We already have -Wall, which enables -Wswitch by default, and per GCC +documentation, "The only difference between -Wswitch and this option +[-Wswitch-enum] is that this option gives a warning about an omitted +enumeration code even if there is a default label." + +Drop -Wswitch-enum to not force listing all named codes of +enumerations in switch statements that have a default label. + +--- + +This will be useful in the next patch. +--- + configure | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure b/configure +index dc0dba4..4433f42 100755 +--- a/configure ++++ b/configure +@@ -528,7 +528,7 @@ fi + + WARN_CXXFLAGS="" + printf "Checking for available C++ compiler warning flags... " +-for flag in -Wall -Wextra -Wwrite-strings -Wswitch-enum; do ++for flag in -Wall -Wextra -Wwrite-strings; do + if ${CC} $flag -o minimal minimal.c > /dev/null 2>&1 + then + WARN_CXXFLAGS="${WARN_CXXFLAGS}${WARN_CXXFLAGS:+ }${flag}" +-- +1.7.9.5 + -- 2.26.2