From 9562f27ef8bd9b3debdac9e54898e9e98d2db48a Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Wed, 4 Apr 2012 15:51:26 +1700 Subject: [PATCH] Re: [PATCH 6/8] cli: add support for batch tagging operations to "notmuch tag" --- 89/54793168fd82fc0618dab7d50f93dd5f190916 | 111 ++++++++++++++++++++++ 1 file changed, 111 insertions(+) create mode 100644 89/54793168fd82fc0618dab7d50f93dd5f190916 diff --git a/89/54793168fd82fc0618dab7d50f93dd5f190916 b/89/54793168fd82fc0618dab7d50f93dd5f190916 new file mode 100644 index 000000000..67c329a82 --- /dev/null +++ b/89/54793168fd82fc0618dab7d50f93dd5f190916 @@ -0,0 +1,111 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 94E55431FB6 + for ; Tue, 3 Apr 2012 15:51:33 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id N8cOaYIDJDts for ; + Tue, 3 Apr 2012 15:51:33 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id F35D8431FAE + for ; Tue, 3 Apr 2012 15:51:32 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 7D65266E012C; + Tue, 3 Apr 2012 15:51:32 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (gwave-107.ligo.caltech.edu + [131.215.114.107]) (Authenticated sender: jrollins) by earth-doxen-submit + (Postfix) with ESMTP id 776EC66E0124; Tue, 3 Apr 2012 15:51:28 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 58D97888; Tue, 3 Apr 2012 15:51:28 -0700 (PDT) +From: Jameson Graef Rollins +To: Jani Nikula +Subject: Re: [PATCH 6/8] cli: add support for batch tagging operations to + "notmuch tag" +In-Reply-To: <87pqbpxm2c.fsf@nikula.org> +References: + + <87ty123tpc.fsf@servo.finestructure.net> + <87aa2tc22z.fsf@zancas.localnet> + <87iphh50hz.fsf@servo.finestructure.net> + + <87fwcl4yr8.fsf@servo.finestructure.net> + + <87d37p4xor.fsf@servo.finestructure.net> + <87pqbpxm2c.fsf@nikula.org> +User-Agent: Notmuch/0.12+87~g3c4c85f (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 03 Apr 2012 15:51:26 -0700 +Message-ID: <87wr5w2zv5.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 03 Apr 2012 22:51:34 -0000 + +--=-=-= + +On Tue, Apr 03 2012, Jani Nikula wrote: +> Yes, it's more flexible, but what are the real benefits of such +> flexibility? What other commands than tag/restore would truly benefit +> from this? I might add that nobody has asked for such flexibility. + +But I do believe it was your patch that introduced the idea of batch +processing of other commands to begin with. I think you're just turning +my original question to you back on me. There's no point in adding and +initial flag to the beginning of the line to specify the command to +execute if you have no intention of ever supporting other commands. Or +vice versa, if you ultimately want to support multiple commands then the +place to do it is in the top level interface, and not in one of the +subcommands. + +Ultimately, I think this patch series suffers from being simultaneously +too close to existing functionality (restore), yet tantalizingly close +to a much more generally useful concept of batch command processing. I +would rather see it go one way or the other rather than add something +fairly redundant in the middle. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPe37uAAoJEO00zqvie6q8CcsP/jRE8/1GrRi22D6OpIjC1izQ +ZnYbrDglAxlS3LHzDZovntJowusbyg1in3MBeLiq/DGS0dNj0hWF4IaaVJ2cz1ph +aj08vCiR0q0tpMAG+J09o8dEp5kJlwzQQtstTrxiamCzdEjgRKha5rQcvsf3lFDw +PKO/sDZRo/reUU4PzXQRsDUkhVCJSiq4fxnzBj+eO5aBrmJxSHFL9rhk6UFoT2Lq +Su7fVR9PnDJ0KodRSQKF/7R/TUoBZEUwv88wUbFTM2WCqqZ6vgEYpIOZZOIsR9OQ +0Eyp9PuhjKG03bKyzdpmN2z8YV7nw3W+MJKRBQep9g/MgkzbiV40kXzUe05nTlw8 +hmnt+HKL5PmdAI3R76B5otP9+ipunkAYz7PpcG4AX/raZVCCayJ33SfSCy9cdcu4 +bvAF8D7oOCpn+buB4x+VvBjWNi09hPUo4MxNPtWv95yZBBblh6vSdgS6Y3SdNMQg +qIS2TanZfJqMiI7TY8UvpNxEeHScQQi/7EVdcOpvgoCW5vicLI5PZpkvAz2gi4u8 +8Srx+t8Ycoq8sFaPgflT5brDDI6txu9pz4vz/2qcPeZb+/AvamQ+NqkDB/gcZlYO +qiJZzGy72aK/8G2YCqetChZhA3biX3h0YxYZm888fwsLLB/40lYm7dNKn2JWR/BN +ipPqDbV9zcvFDeOLWxj2 +=EbJM +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2