From 951d251f048bf3ecbd00dbd2c2a39f36354d84d6 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 11 Oct 2013 08:02:19 +2100 Subject: [PATCH] Re: [PATCH 0/3] General fixes --- 90/14e7832222e15439beb3c1538a6c9db9a2ae13 | 69 +++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 90/14e7832222e15439beb3c1538a6c9db9a2ae13 diff --git a/90/14e7832222e15439beb3c1538a6c9db9a2ae13 b/90/14e7832222e15439beb3c1538a6c9db9a2ae13 new file mode 100644 index 000000000..8cc45f326 --- /dev/null +++ b/90/14e7832222e15439beb3c1538a6c9db9a2ae13 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6DC01431FAF + for ; Thu, 10 Oct 2013 04:02:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4YHgCNOM3Cs0 for ; + Thu, 10 Oct 2013 04:02:23 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id ABBC3431FAE + for ; Thu, 10 Oct 2013 04:02:23 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VUE0d-0001bG-4Y; Thu, 10 Oct 2013 08:02:23 -0300 +Received: (nullmailer pid 19848 invoked by uid 1000); Thu, 10 Oct 2013 + 11:02:19 -0000 +From: David Bremner +To: Felipe Contreras , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/3] General fixes +In-Reply-To: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com> +References: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com> +User-Agent: Notmuch/0.16+92~g54c40fb (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 10 Oct 2013 08:02:19 -0300 +Message-ID: <87txgpv16s.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 10 Oct 2013 11:02:28 -0000 + +Felipe Contreras writes: + +> Felipe Contreras (3): +> query: bind queries to database objects +> ruby: allow build with RUNPATH +> ruby: bind database close()/destroy() properly + +Hi Felipe; + +I agree with the discussion on IRC that the change in the first patch +makes sense. + +It would be nice to have a bit more explanation in the commit message of +the second message; at least to point out that (iiuc) this is not a +really a ruby specific thing, just a standard ld.so feature. + +d + -- 2.26.2