From 93f0958049027e7ef8806b7fcf327921e4fdd0a3 Mon Sep 17 00:00:00 2001 From: Ethan Date: Tue, 20 Nov 2012 23:50:48 +1900 Subject: [PATCH] Re: [PATCH v2] emacs: display tags in notmuch-show with links --- 4e/1266893f7570634244e119b3d6a4c04f1388af | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 4e/1266893f7570634244e119b3d6a4c04f1388af diff --git a/4e/1266893f7570634244e119b3d6a4c04f1388af b/4e/1266893f7570634244e119b3d6a4c04f1388af new file mode 100644 index 000000000..b68a30aff --- /dev/null +++ b/4e/1266893f7570634244e119b3d6a4c04f1388af @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id AC3A5431FC4 + for ; Mon, 19 Nov 2012 20:51:10 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.798 +X-Spam-Level: +X-Spam-Status: No, score=-0.798 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fuYJ81PUR3u7 for ; + Mon, 19 Nov 2012 20:51:10 -0800 (PST) +Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com + [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 42D14431FBC + for ; Mon, 19 Nov 2012 20:51:10 -0800 (PST) +Received: by mail-vb0-f53.google.com with SMTP id b23so957698vbz.26 + for ; Mon, 19 Nov 2012 20:51:09 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:from:date:message-id:subject:to + :cc:content-type; + bh=3boXrEsyYhSw0oVY8g6Lcgqwc9VYa/xtI1o5THjoFiQ=; + b=JC+G4+J7FcA+tDEvd5AAWTWEOMg0ZOjI7+6digKGkHD0EBQVLiJIMVIg7VvHNybC7/ + RM0XaIK261UFLeAa0bpAXzq2JVn7kK6zCgh5LhlA83oyPnmGt/D0ok+I/2BZBBmaqN5+ + 1Z4YdQ+5rdN7uWuT8QI4oqL/UVwWjZhEIf/YVFkMbv3KlJ3ig8SuVm1LIva8u81i6mXJ + fKtBlLjERKcdOxc6HZL49H6tBHy7mjUhYZRw3leeFpgkHyZOiATKjN+i4WRo5eiFYXvQ + Owv4nrlvZfGL7vrtxXQ0gfKD+wqEfGkaL4zo/nXsTuOmAq2Z5Df8UCZUKEe5y6Eplv/K + ixSg== +Received: by 10.59.12.161 with SMTP id er1mr19973574ved.19.1353387068598; Mon, + 19 Nov 2012 20:51:08 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.220.247.209 with HTTP; Mon, 19 Nov 2012 20:50:48 -0800 (PST) +In-Reply-To: <20121120042302.GF22284@mit.edu> +References: <1353266322-20318-1-git-send-email-damien.cassou@gmail.com> + <87ip921pqu.fsf@betacantrips.com> <20121120042302.GF22284@mit.edu> +From: Ethan +Date: Mon, 19 Nov 2012 23:50:48 -0500 +Message-ID: + +Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links +To: Austin Clements +Content-Type: multipart/alternative; boundary=089e011849b277a9a204cee5fb02 +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 20 Nov 2012 04:51:10 -0000 + +--089e011849b277a9a204cee5fb02 +Content-Type: text/plain; charset=ISO-8859-1 + +On Mon, Nov 19, 2012 at 11:23 PM, Austin Clements wrote: + +> This seems like overkill given that all of the common code in +> notmuch-tagger-{body,header}-button-action is already abstracted into +> a common function. Were there other places where code was duplicated +> because of the difference between regular buttons and header buttons? +> + +I guess you're right, that's the only place and it isn't worth worrying +about. + +Ethan + +--089e011849b277a9a204cee5fb02 +Content-Type: text/html; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable + +
On Mon, Nov 19, 2012 at 11:23 PM, Austin Clement= +s <amdragon@mit.edu> wrote:
+ +This seems like overkill given that all of the common code in
+notmuch-tagger-{body,header}-button-action is already abstracted into
+a common function. =A0Were there other places where code was duplicated
+because of the difference between regular buttons and header buttons?

I guess you're right, that's the only place and= + it isn't worth worrying about.

Ethan
=A0
+ +--089e011849b277a9a204cee5fb02-- -- 2.26.2