From 8ed7250e9c332a35a25bbeaff2535a8a334b3f01 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Mon, 30 Apr 2012 19:02:20 +2000 Subject: [PATCH] Re: [Patch v2 0/3] emacs: allow show to colour based on tags and flags --- 9c/56068b28e74e47c469ba0720169fb72891b359 | 115 ++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 9c/56068b28e74e47c469ba0720169fb72891b359 diff --git a/9c/56068b28e74e47c469ba0720169fb72891b359 b/9c/56068b28e74e47c469ba0720169fb72891b359 new file mode 100644 index 000000000..7b9939398 --- /dev/null +++ b/9c/56068b28e74e47c469ba0720169fb72891b359 @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CD927431FAF + for ; Sun, 29 Apr 2012 16:02:23 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8cc8Zpq5LwYZ for ; + Sun, 29 Apr 2012 16:02:23 -0700 (PDT) +Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id 3B0EE431FAE + for ; Sun, 29 Apr 2012 16:02:23 -0700 (PDT) +X-AuditID: 1209190f-b7f4f6d00000092b-31-4f9dc87ece4e +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 38.ED.02347.E78CD9F4; Sun, 29 Apr 2012 19:02:22 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q3TN2Mkr032629; + Sun, 29 Apr 2012 19:02:22 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q3TN2KPt021627 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sun, 29 Apr 2012 19:02:21 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SOd8G-00049m-Ny; Sun, 29 Apr 2012 19:02:20 -0400 +Date: Sun, 29 Apr 2012 19:02:20 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [Patch v2 0/3] emacs: allow show to colour based on tags and + flags +Message-ID: <20120429230220.GO2704@mit.edu> +References: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFvrPIsWRmVeSWpSXmKPExsUixCmqrVt3Yq6/Qdt9I4vVc3ksrt+cyezA + 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZew8PpW1YBpPxZV1Qg2Mzzi7GDk5JARMJO5P + msUKYYtJXLi3nq2LkYtDSGAfo8SCZ8ugnA2MEheuPmWGcE4ySfzbsYgFwlnCKNE8cT9QPwcH + i4CqxJ3njCCj2AQ0JLbtXw5miwjoSNw+tIAdxGYWkJb49ruZCaRcWCBQ4t8vcZAwr4C2RMvc + /ywgYSEBD4n+Y2IQYUGJkzOfsEB0aknc+PcSrBNkyvJ/HCBhTgFPicc/vrOB2KICKhJTTm5j + m8AoNAtJ9ywk3bMQuhcwMq9ilE3JrdLNTczMKU5N1i1OTszLSy3SNdHLzSzRS00p3cQIDmdJ + /h2M3w4qHWIU4GBU4uEVyp3jL8SaWFZcmXuIUZKDSUmUt+LYXH8hvqT8lMqMxOKM+KLSnNTi + Q4wSHMxKIrza4kDlvCmJlVWpRfkwKWkOFiVxXjWtd35CAumJJanZqakFqUUwWRkODiUJ3rXH + gYYKFqWmp1akZeaUIKSZODhBhvMADT8FUsNbXJCYW5yZDpE/xagoJc7bB5IQAElklObB9cLS + zStGcaBXhHmnglTxAFMVXPcroMFMQIOZPGeBDC5JREhJNTAqV3Q92pifOsG9ii/oEmv/9tSK + u2vjrRnfVgu1XuyU2lY44cSOqkqf2vnrZyS/3X15mffUA9pcO+1Z/mmV5fRPblSYzq2pOO+j + 8OnFspllm//ut2c9XLyc893RKu+EEvOzkWe3zJg2d49s84tio8pGiwwV7tc72V7+3sA+dWem + c8iynxKC1lOUWIozEg21mIuKEwEarODLEgMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 29 Apr 2012 23:02:23 -0000 + +I haven't really looked at this series yet, but I do have a quick +high-level question. Why use separate customization variables for the +colors in search and show mode? Wouldn't it make more sense to set +the colors just once and use them in both modes? + +BTW, I like how this clearly distinguishes tags and flags. I wonder +if we could transition to flags for some information that's current +shoe-horned into tags but actually represents immutable information +about a message (attachment, signed, and encrypted or so). + +My one concern is that there's a common tag called "flagged", so this +might be overloading terminology. + +Quoth Mark Walters on Apr 29 at 11:48 pm: +> This is a rebased (but otherwise unchanged) version of +> id:"1334431301-27303-1-git-send-email-markwalters1009@gmail.com". +> +> It's probably too late for 0.13 but in case anyone would like to look +> at it this version applies cleanly to master so should be easier to +> test. +> +> The first two patches are basically David Edmondson's patch +> id:"1325006003-27152-1-git-send-email-dme@dme.org". +> +> Best wishes +> +> Mark +> +> +> Mark Walters (3): +> emacs: Move colour line from search to lib +> emacs: Add `notmuch-show-line-faces' and apply it. +> emacs: allow notmuch-show-line-faces to use flags for colouring +> +> emacs/notmuch-lib.el | 18 ++++++++++++++++++ +> emacs/notmuch-show.el | 44 ++++++++++++++++++++++++++++++++++++++++---- +> emacs/notmuch.el | 15 +-------------- +> 3 files changed, 59 insertions(+), 18 deletions(-) -- 2.26.2