From 8e3661c74961e58c5b1b50151489454a56e27a7f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 1 Feb 2012 10:55:50 +0200 Subject: [PATCH] Re: [PATCH] test: make test_expect_equal_file() arguments flexible --- 8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2 | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2 diff --git a/8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2 b/8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2 new file mode 100644 index 000000000..945f1a337 --- /dev/null +++ b/8a/504111b56272e0ba1b24e46ddbe1f0e6ae92d2 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 53591431E64 + for ; Wed, 1 Feb 2012 00:55:48 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id aY+w65I2oZuz for ; + Wed, 1 Feb 2012 00:55:47 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id BEAE1431FAF + for ; Wed, 1 Feb 2012 00:55:47 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 920B468055; Wed, 1 Feb 2012 10:55:50 +0200 (EET) +From: Tomi Ollila +To: Jameson Graef Rollins , + Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible +In-Reply-To: <87r4yfszx9.fsf@servo.finestructure.net> +References: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com> + <87r4yfszx9.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.11+146~geb6dc33 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 01 Feb 2012 08:55:48 -0000 + +On Wed, 01 Feb 2012 00:47:30 -0800, Jameson Graef Rollins wrote: +> On Wed, 1 Feb 2012 11:19:54 +0400, Dmitry Kurochkin wrote: +> > The down side of this approach is that diff argument order depends on +> > test_expect_equal_file() argument order. So sometimes we get diff +> > from expected to actual results, and sometimes the other way around. +> > But the files are always named correctly. +> +> Actually, I think this last point is the most important thing to retain. +> Consistency in the diffs makes reading test results much more efficient. +> The order I don't much care about. But seeing as we have been +> consistent with a particular order for a while, it seems like more +> effort than it's worth to change it. + +how about enforcing it in the test suite ? + +case $file2 in + *.expected|*.EXPECTED) ;; + *) echo "$file2" does not end with 'expected' >&2; exit 1 +esac + +> +> jamie. + +Tomi -- 2.26.2