From 8e1bff5146ca3f6305ce7349b963c8fa19bc9b63 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20G=C3=B3rny?= Date: Thu, 23 Feb 2017 19:20:01 +0100 Subject: [PATCH] ruby-fakegem.eclass: Remove completely unnecessary 'eval ls' Filename expansion is performed when the variable is referenced unquoted already. There is really no need to call 'ls' on top of that, and even less reason to wrap it all in 'eval'. --- eclass/ruby-fakegem.eclass | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/eclass/ruby-fakegem.eclass b/eclass/ruby-fakegem.eclass index 69ab29f7fb85..b1795fa46c93 100644 --- a/eclass/ruby-fakegem.eclass +++ b/eclass/ruby-fakegem.eclass @@ -521,9 +521,8 @@ all_fakegem_install() { if [[ -d "${bindir}" ]]; then pushd "${bindir}" &>/dev/null || die - local binaries=$(eval ls ${RUBY_FAKEGEM_BINWRAP}) - for binary in $binaries; do - ruby_fakegem_binwrapper $binary + for binary in ${RUBY_FAKEGEM_BINWRAP}; do + ruby_fakegem_binwrapper "${binary}" done popd &>/dev/null || die fi -- 2.26.2