From 8dea268f0f9ea60c19411487642cf9ed24c4ce7c Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 30 Jan 2012 16:59:54 +0200 Subject: [PATCH] Re: [PATCH 2/2] show: Simplify new text formatter code --- d4/958e4fe6da5013718f38b761cf2b76ae773cb0 | 65 +++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 d4/958e4fe6da5013718f38b761cf2b76ae773cb0 diff --git a/d4/958e4fe6da5013718f38b761cf2b76ae773cb0 b/d4/958e4fe6da5013718f38b761cf2b76ae773cb0 new file mode 100644 index 000000000..51c6d7317 --- /dev/null +++ b/d4/958e4fe6da5013718f38b761cf2b76ae773cb0 @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5BBF4429E34 + for ; Mon, 30 Jan 2012 06:59:51 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DpGnuLnagCQa for ; + Mon, 30 Jan 2012 06:59:51 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id E1242431FBC + for ; Mon, 30 Jan 2012 06:59:50 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 07C4368056; Mon, 30 Jan 2012 16:59:54 +0200 (EET) +From: Tomi Ollila +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] show: Simplify new text formatter code +In-Reply-To: <1327560926-22401-3-git-send-email-amdragon@mit.edu> +References: <1327560926-22401-1-git-send-email-amdragon@mit.edu> + <1327560926-22401-3-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.11+128~g6f388fa (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 14:59:51 -0000 + +On Thu, 26 Jan 2012 01:55:26 -0500, Austin Clements wrote: +> This makes the text formatter take advantage of the new code +> structure. The previously duplicated header logic is now unified, +> several things that we used to compute repeatedly across different +> callbacks are now computed once, and the code is simpler overall and +> 32% shorter. +> +> Unifying the header logic causes this to format some dates slightly +> differently, so the two affected test cases are updated. +> --- + +Looks good, works fine. + + +Tomi -- 2.26.2