From 8aa406987e1009a3dfbd7019068c81105c45407f Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Tue, 31 Jan 2012 16:23:32 +0000 Subject: [PATCH] Re: [PATCH 3/5] emacs: Allow the indentation of content to be toggled. --- 7c/62147d41934e5150b72c441626ddd458df8300 | 112 ++++++++++++++++++++++ 1 file changed, 112 insertions(+) create mode 100644 7c/62147d41934e5150b72c441626ddd458df8300 diff --git a/7c/62147d41934e5150b72c441626ddd458df8300 b/7c/62147d41934e5150b72c441626ddd458df8300 new file mode 100644 index 000000000..13d0c94e9 --- /dev/null +++ b/7c/62147d41934e5150b72c441626ddd458df8300 @@ -0,0 +1,112 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1DF2A414BA1 + for ; Tue, 31 Jan 2012 08:23:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id MQDTp3g6Isk9 for ; + Tue, 31 Jan 2012 08:23:40 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7EA4E414B9C + for ; Tue, 31 Jan 2012 08:23:40 -0800 (PST) +Received: by wibhi8 with SMTP id hi8so115282wib.26 + for ; Tue, 31 Jan 2012 08:23:39 -0800 (PST) +Received: by 10.180.97.199 with SMTP id ec7mr35464778wib.8.1328027019274; + Tue, 31 Jan 2012 08:23:39 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id l12sm39385540wiw.0.2012.01.31.08.23.37 + (version=TLSv1/SSLv3 cipher=OTHER); + Tue, 31 Jan 2012 08:23:38 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id 2FBBB9FF33; Tue, 31 Jan 2012 16:23:36 +0000 (GMT) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 3/5] emacs: Allow the indentation of content to be + toggled. +In-Reply-To: <87d39zu9v4.fsf@qmul.ac.uk> +References: + <1327999620-14595-1-git-send-email-dme@dme.org> + <1327999620-14595-4-git-send-email-dme@dme.org> + <87d39zu9v4.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.11+137~g7cd907b (http://notmuchmail.org) Emacs/24.0.92.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Tue, 31 Jan 2012 16:23:32 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 31 Jan 2012 16:23:41 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Tue, 31 Jan 2012 16:15:11 +0000, Mark Walters wrote: +> Hi I have reviewed the patch series within the limits of my lisp +> knowledge. Patch 1: is rather beyond my lisp so I won't comment on that +> (and I have never tried crypto): Patches 2-5 look fine with one +> bikeshed and one query for my own understanding. + +Thanks. + +> The bikeshed is that I agree with Jani in +> id:"CAB+hUn8KhXHTRCdrLe0cT=3D8mdtz9ZntPFf13mq0iCo4CX=3DB-Jg@mail.gmail.co= +m" +> that I would prefer to reserve '>' for saving a file. + +'<' is 'remove indent', or 'look to the left'. +'>' is 'toggle truncation', or 'look to the right'. + +(I'm not overly worried about this - would 't' be more acceptable?) + +> The query: in +>=20 +> > + (props (notmuch-show-get-message-properties)) +> > + (indenting notmuch-show-indent-content)) +> > (with-temp-buffer +> > (insert all) +> > - (indent-rigidly (point-min) (point-max) (- depth)) +> > + (if indenting +> > + (indent-rigidly (point-min) (point-max) (- depth))) +>=20 +> Is the local variable `indenting' needed because +> notmuch-show-indent-content is buffer local and this is in the +> with-temp-buffer? + +Yes. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk8oFYQACgkQaezQq/BJZRbv6ACeOBY/LFrsCxpjKIAY/3tmCYaM +QbMAnRU+yUqXeRnLF6sMXfeLppNQ80Zs +=hlut +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2