From 8a70617a75d4665ab1772957ae2d436b961c09e4 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Mon, 5 Mar 2012 09:24:33 +0200 Subject: [PATCH] Re: [PATCH] emacs: keep customizations in groups --- 63/82402d18da2d65a40bc85029b720ffb28a2eba | 236 ++++++++++++++++++++++ 1 file changed, 236 insertions(+) create mode 100644 63/82402d18da2d65a40bc85029b720ffb28a2eba diff --git a/63/82402d18da2d65a40bc85029b720ffb28a2eba b/63/82402d18da2d65a40bc85029b720ffb28a2eba new file mode 100644 index 000000000..083324e09 --- /dev/null +++ b/63/82402d18da2d65a40bc85029b720ffb28a2eba @@ -0,0 +1,236 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 49418431FBC + for ; Sun, 4 Mar 2012 23:24:36 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rz6mRokxkK92 for ; + Sun, 4 Mar 2012 23:24:34 -0800 (PST) +Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com + [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5B459431FAE + for ; Sun, 4 Mar 2012 23:24:34 -0800 (PST) +Received: by dadp14 with SMTP id p14so3268881dad.18 + for ; Sun, 04 Mar 2012 23:24:33 -0800 (PST) +Received-SPF: pass (google.com: domain of jani@nikula.org designates + 10.68.225.73 as permitted sender) client-ip=10.68.225.73; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of jani@nikula.org + designates 10.68.225.73 as permitted sender) + smtp.mail=jani@nikula.org +Received: from mr.google.com ([10.68.225.73]) + by 10.68.225.73 with SMTP id ri9mr45614452pbc.70.1330932273515 + (num_hops = 1); Sun, 04 Mar 2012 23:24:33 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.68.225.73 with SMTP id ri9mr39027932pbc.70.1330932273252; Sun, + 04 Mar 2012 23:24:33 -0800 (PST) +Received: by 10.68.12.103 with HTTP; Sun, 4 Mar 2012 23:24:33 -0800 (PST) +Received: by 10.68.12.103 with HTTP; Sun, 4 Mar 2012 23:24:33 -0800 (PST) +In-Reply-To: + +References: <1330811724-30901-1-git-send-email-jani@nikula.org> + <87d38r6i0s.fsf@qmul.ac.uk> + +Date: Mon, 5 Mar 2012 09:24:33 +0200 +Message-ID: + +Subject: Re: [PATCH] emacs: keep customizations in groups +From: Jani Nikula +To: Mark Walters +Content-Type: multipart/alternative; boundary=e89a8ff2437d5e0a0104ba79d128 +X-Gm-Message-State: + ALoCoQkLYo+ro36GpsM3JvNRB1ex3ukiIigt2/QICYrFte9qR6/zcP0y9Sj0k1H0t79fpaXV7HR3 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 05 Mar 2012 07:24:36 -0000 + +--e89a8ff2437d5e0a0104ba79d128 +Content-Type: text/plain; charset=UTF-8 + +On Mar 5, 2012 1:50 AM, "Mark Walters" wrote: +> +> On Sat, 3 Mar 2012 23:55:24 +0200, Jani Nikula wrote: +> > Move hello section customization to notmuch-hello group and printing +> > customization to notmuch-show group from the top level customization +> > group. +> +> Hi +> +> This is an clear improvement but I wonder about the positioning of these +> two options inside the subgroups. It makes +> +> notmuch-hello-sections the last option under notmuch-hello and +> +> notmuch-print-mechanism the first option under notmuch-show +> +> both of which seem slightly strange positions. +> +> (Personally I would place notmuch-hello-sections towards the top, and +> notmuch-print-mechanism towards the bottom. If you decided on this +> ordering then I am happy to go with it: I am only commenting in case it +> is just accidental.) + +I just changed the groups, and that's where the options landed... I don't +know how to change the order. + +> +> Best wishes +> +> Mark +> +> +> +> > --- +> > emacs/notmuch-hello.el | 2 +- +> > emacs/notmuch-print.el | 2 +- +> > 2 files changed, 2 insertions(+), 2 deletions(-) +> > +> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el +> > index e089290..0cf613f 100644 +> > --- a/emacs/notmuch-hello.el +> > +++ b/emacs/notmuch-hello.el +> > @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the count +of messages +> > displayed next to the buttons can be generated by applying a +> > different filter to the tag query. These filters are also +> > supported for \"Customized queries section\" items." +> > - :group 'notmuch +> > + :group 'notmuch-hello +> > :type +> > '(repeat +> > (choice (function-item notmuch-hello-insert-header) +> > diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el +> > index 6653d97..8c18f4b 100644 +> > --- a/emacs/notmuch-print.el +> > +++ b/emacs/notmuch-print.el +> > @@ -25,7 +25,7 @@ +> > +> > (defcustom notmuch-print-mechanism 'notmuch-print-lpr +> > "How should printing be done?" +> > - :group 'notmuch +> > + :group 'notmuch-show +> > :type '(choice +> > (function :tag "Use lpr" notmuch-print-lpr) +> > (function :tag "Use ps-print" notmuch-print-ps-print) +> > -- +> > 1.7.5.4 +> > +> > _______________________________________________ +> > notmuch mailing list +> > notmuch@notmuchmail.org +> > http://notmuchmail.org/mailman/listinfo/notmuch + +--e89a8ff2437d5e0a0104ba79d128 +Content-Type: text/html; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +


+On Mar 5, 2012 1:50 AM, "Mark Walters" <markwalters1009@gmail.com> wrote:
+>
+> On Sat, =C2=A03 Mar 2012 23:55:24 +0200, Jani Nikula <jani@nikula.org> wrote:
+> > Move hello section customization to notmuch-hello group and print= +ing
+> > customization to notmuch-show group from the top level customizat= +ion
+> > group.
+>
+> Hi
+>
+> This is an clear improvement but I wonder about the positioning of the= +se
+> two options inside the subgroups. It makes
+>
+> notmuch-hello-sections the last option under notmuch-hello and
+>
+> notmuch-print-mechanism the first option under notmuch-show
+>
+> both of which seem slightly strange positions.
+>
+> (Personally I would place notmuch-hello-sections towards the top, and<= +br> +> notmuch-print-mechanism towards the bottom. If you decided on this
+> ordering then I am happy to go with it: I am only commenting in case i= +t
+> is just accidental.)

+

I just changed the groups, and that's where the options landed... I = +don't know how to change the order.

+

>
+> Best wishes
+>
+> Mark
+>
+>
+>
+> > ---
+> > =C2=A0emacs/notmuch-hello.el | =C2=A0 =C2=A02 +-
+> > =C2=A0emacs/notmuch-print.el | =C2=A0 =C2=A02 +-
+> > =C2=A02 files changed, 2 insertions(+), 2 deletions(-)
+> >
+> > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
+> > index e089290..0cf613f 100644
+> > --- a/emacs/notmuch-hello.el
+> > +++ b/emacs/notmuch-hello.el
+> > @@ -226,7 +226,7 @@ by an additional filter query. Similarly, the= + count of messages
+> > =C2=A0displayed next to the buttons can be generated by applying = +a
+> > =C2=A0different filter to the tag query. These filters are also +> > =C2=A0supported for \"Customized queries section\" item= +s."
+> > - =C2=A0:group 'notmuch
+> > + =C2=A0:group 'notmuch-hello
+> > =C2=A0 =C2=A0:type
+> > =C2=A0 =C2=A0'(repeat
+> > =C2=A0 =C2=A0 =C2=A0(choice (function-item notmuch-hello-insert-h= +eader)
+> > diff --git a/emacs/notmuch-print.el b/emacs/notmuch-print.el
+> > index 6653d97..8c18f4b 100644
+> > --- a/emacs/notmuch-print.el
+> > +++ b/emacs/notmuch-print.el
+> > @@ -25,7 +25,7 @@
+> >
+> > =C2=A0(defcustom notmuch-print-mechanism 'notmuch-print-lpr +> > =C2=A0 =C2=A0"How should printing be done?"
+> > - =C2=A0:group 'notmuch
+> > + =C2=A0:group 'notmuch-show
+> > =C2=A0 =C2=A0:type '(choice
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 (function :tag "Use lpr" no= +tmuch-print-lpr)
+> > =C2=A0 =C2=A0 =C2=A0 =C2=A0 (function :tag "Use ps-print&quo= +t; notmuch-print-ps-print)
+> > --
+> > 1.7.5.4
+> >
+> > _______________________________________________
+> > notmuch mailing list
+> > notmuch@notmuchmail.or= +g
+> > http:= +//notmuchmail.org/mailman/listinfo/notmuch
+

+ +--e89a8ff2437d5e0a0104ba79d128-- -- 2.26.2