From 8a4a1986654c6e5e93e8667cbfe82710ef75eacb Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Mon, 30 Apr 2012 00:37:22 +0100 Subject: [PATCH] Re: [Patch v2 0/3] emacs: allow show to colour based on tags and flags --- 4f/ceb59612cc582a2ec32d3350b8cba85ede108d | 141 ++++++++++++++++++++++ 1 file changed, 141 insertions(+) create mode 100644 4f/ceb59612cc582a2ec32d3350b8cba85ede108d diff --git a/4f/ceb59612cc582a2ec32d3350b8cba85ede108d b/4f/ceb59612cc582a2ec32d3350b8cba85ede108d new file mode 100644 index 000000000..ebe738372 --- /dev/null +++ b/4f/ceb59612cc582a2ec32d3350b8cba85ede108d @@ -0,0 +1,141 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 43D34431FAF + for ; Sun, 29 Apr 2012 16:37:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id s-ZQa8g7FemK for ; + Sun, 29 Apr 2012 16:37:09 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 8B8B4431FAE + for ; Sun, 29 Apr 2012 16:37:09 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SOdfr-0002KO-UB; Mon, 30 Apr 2012 00:37:04 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SOdfr-00031c-JA; Mon, 30 Apr 2012 00:37:03 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/3] emacs: allow show to colour based on tags and + flags +In-Reply-To: <20120429230220.GO2704@mit.edu> +References: <1335739697-8501-1-git-send-email-markwalters1009@gmail.com> + <20120429230220.GO2704@mit.edu> +User-Agent: Notmuch/0.12+128~g0f26d91 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 30 Apr 2012 00:37:22 +0100 +Message-ID: <87k40yyurx.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 8146f51d46245f742d8722bb154f480f (of first 20000 bytes) +X-SpamAssassin-Score: -1.2 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.2 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * 0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 29 Apr 2012 23:37:13 -0000 + + +On Mon, 30 Apr 2012, Austin Clements wrote: +> I haven't really looked at this series yet, but I do have a quick +> high-level question. Why use separate customization variables for the +> colors in search and show mode? Wouldn't it make more sense to set +> the colors just once and use them in both modes? + +I think that their use is somewhat different since in show mode the +colour can be quite high contrast because mostly you only have a few +header lines (that may depend how much time you spend in +expanded/collapsed views); one example is that in show mode the header +line normally has a background colour (I think even without +customisation) whereas in search mode that would be weird as every line +would have it. + +> BTW, I like how this clearly distinguishes tags and flags. I wonder +> if we could transition to flags for some information that's current +> shoe-horned into tags but actually represents immutable information +> about a message (attachment, signed, and encrypted or so). + +Yes some of those could make sense: I hadn't thought about them at +all. I think attachment is closer to a genuine tag as I frequently include +tag:attachment in my searched but I would guess that searching for +signed/encrypted is not as common (but I don't use either so could be wrong) + +> My one concern is that there's a common tag called "flagged", so this +> might be overloading terminology. + +I hadn't thought of that: I agree but don't have a good suggestion for +avoiding it. + +Best wishes + +Mark + + +> +> Quoth Mark Walters on Apr 29 at 11:48 pm: +>> This is a rebased (but otherwise unchanged) version of +>> id:"1334431301-27303-1-git-send-email-markwalters1009@gmail.com". +>> +>> It's probably too late for 0.13 but in case anyone would like to look +>> at it this version applies cleanly to master so should be easier to +>> test. +>> +>> The first two patches are basically David Edmondson's patch +>> id:"1325006003-27152-1-git-send-email-dme@dme.org". +>> +>> Best wishes +>> +>> Mark +>> +>> +>> Mark Walters (3): +>> emacs: Move colour line from search to lib +>> emacs: Add `notmuch-show-line-faces' and apply it. +>> emacs: allow notmuch-show-line-faces to use flags for colouring +>> +>> emacs/notmuch-lib.el | 18 ++++++++++++++++++ +>> emacs/notmuch-show.el | 44 ++++++++++++++++++++++++++++++++++++++++---- +>> emacs/notmuch.el | 15 +-------------- +>> 3 files changed, 59 insertions(+), 18 deletions(-) -- 2.26.2