From 8967f6ac2fbbaab75689841de836efa4dcce7533 Mon Sep 17 00:00:00 2001 From: Vladimir Marek Date: Tue, 10 Apr 2012 08:53:24 +0200 Subject: [PATCH] Re: [PATCH 4/4] Explicitly type void* pointers --- 12/eacf67d0994361bb44f97f19500e2c7e6ec77b | 91 +++++++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 12/eacf67d0994361bb44f97f19500e2c7e6ec77b diff --git a/12/eacf67d0994361bb44f97f19500e2c7e6ec77b b/12/eacf67d0994361bb44f97f19500e2c7e6ec77b new file mode 100644 index 000000000..77b4b7ef5 --- /dev/null +++ b/12/eacf67d0994361bb44f97f19500e2c7e6ec77b @@ -0,0 +1,91 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F3FA8431FAF + for ; Mon, 9 Apr 2012 23:54:02 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -4.999 +X-Spam-Level: +X-Spam-Status: No, score=-4.999 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_HI=-5, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2+4Yw0MuJnh8 for ; + Mon, 9 Apr 2012 23:54:02 -0700 (PDT) +Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 987B7431FAE + for ; Mon, 9 Apr 2012 23:54:02 -0700 (PDT) +Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) + by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with + ESMTP id q3A6rwXE015063 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); + Tue, 10 Apr 2012 06:54:01 GMT +Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) + by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id + q3A6ruBb003807 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); + Tue, 10 Apr 2012 06:53:57 GMT +Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) + by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id + q3A6rt7P003195; Tue, 10 Apr 2012 01:53:55 -0500 +Received: from pub.czech.sun.com (/10.163.20.32) + by default (Oracle Beehive Gateway v4.0) + with ESMTP ; Mon, 09 Apr 2012 23:53:54 -0700 +Date: Tue, 10 Apr 2012 08:53:24 +0200 +From: Vladimir Marek +To: Jani Nikula +Subject: Re: [PATCH 4/4] Explicitly type void* pointers +Message-ID: <20120410065324.GD10554@pub.czech.sun.com> +Mail-Followup-To: Jani Nikula , + Notmuch Mail +References: <1333966665-10469-1-git-send-email-Vladimir.Marek@oracle.com> + <1333966665-10469-5-git-send-email-Vladimir.Marek@oracle.com> + + <20120409181543.GC10554@pub.czech.sun.com> + <87mx6ka8y1.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +In-Reply-To: <87mx6ka8y1.fsf@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Source-IP: acsinet21.oracle.com [141.146.126.237] +X-Auth-Type: Internal IP +X-CT-RefId: str=0001.0A090202.4F83D909.0069,ss=1,re=0.000,fgs=0 +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 10 Apr 2012 06:54:03 -0000 + +[...] + +> I'm throwing in a third alternative below. Does it work for you? I think +> it's both prettier and uglier than the above at the same time! ;) +> +> A middle ground would be to change the callers to use +> "notmuch_talloc_steal", and just #define notmuch_talloc_steal +> talloc_steal if __GNUC__ >= 3. +> +> One could argue upstream talloc should have this, but OTOH it's a C +> library. + +That's a nice trick, and it indeed works for me. And I like it more than +what I suggested. + +Thank you +-- + Vlad -- 2.26.2