From 8965bedc8dff0dbfc8c007004678d54da4ee2f62 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Mon, 6 Feb 2012 23:42:05 +1900 Subject: [PATCH] Re: [PATCH] STYLE: Initial draft of coding style document --- 53/000b44ed06da4bb7329df606af32ce9739682b | 107 ++++++++++++++++++++++ 1 file changed, 107 insertions(+) create mode 100644 53/000b44ed06da4bb7329df606af32ce9739682b diff --git a/53/000b44ed06da4bb7329df606af32ce9739682b b/53/000b44ed06da4bb7329df606af32ce9739682b new file mode 100644 index 000000000..600b42fb6 --- /dev/null +++ b/53/000b44ed06da4bb7329df606af32ce9739682b @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 92EB4431FAF + for ; Sun, 5 Feb 2012 20:43:19 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DwelkUysYqI4 for ; + Sun, 5 Feb 2012 20:43:19 -0800 (PST) +Received: from dmz-mailsec-scanner-4.mit.edu (DMZ-MAILSEC-SCANNER-4.MIT.EDU + [18.9.25.15]) + by olra.theworths.org (Postfix) with ESMTP id D3EA4431FAE + for ; Sun, 5 Feb 2012 20:43:18 -0800 (PST) +X-AuditID: 1209190f-b7f8a6d000000914-71-4f2f5a66ad73 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-4.mit.edu (Symantec Messaging Gateway) with SMTP + id 14.94.02324.66A5F2F4; Sun, 5 Feb 2012 23:43:18 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q164hH0b028102; + Sun, 5 Feb 2012 23:43:17 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q164hFE5020298 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Sun, 5 Feb 2012 23:43:16 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1RuGOz-0005iX-HL; Sun, 05 Feb 2012 23:42:05 -0500 +Date: Sun, 5 Feb 2012 23:42:05 -0500 +From: Austin Clements +To: David Bremner +Subject: Re: [PATCH] STYLE: Initial draft of coding style document +Message-ID: <20120206044205.GQ10898@mit.edu> +References: <1327708018-1107-1-git-send-email-david@tethera.net> + + + <87vcnnjuac.fsf@rocinante.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87vcnnjuac.fsf@rocinante.cs.unb.ca> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFprCKsWRmVeSWpSXmKPExsUixCmqrJsWpe9vsPSjuMXGZT+ZLZqmO1tc + vzmT2eLNynmsDiwev9rmMnsc/rqQxePW/dfsHs9W3WIOYInisklJzcksSy3St0vgyviydQNj + wQaOip53EQ2MB9m6GDk5JARMJF5dnM8CYYtJXLi3HiwuJLCPUeLoTc8uRi4gez2jxJxv3UwQ + zgkmiR03H7BAOEsYJeav3c4K0sIioCLx5Wo7mM0moCGxbf9yRhBbREBN4u6ydjCbWSBVYuvC + WexdjBwcwgJOEh0bs0HCvAI6EienHWWGmHmFUWL5++9MEAlBiZMzn7BA9GpJ3Pj3kgmkl1lA + WmL5Pw4Qk1PAUKLnXSJIhSjQBVNObmObwCg0C0nzLCTNsxCaFzAyr2KUTcmt0s1NzMwpTk3W + LU5OzMtLLdI10cvNLNFLTSndxAgOfEn+HYzfDiodYhTgYFTi4VUw0fcXYk0sK67MPcQoycGk + JMr7LAIoxJeUn1KZkVicEV9UmpNafIhRgoNZSYS3xh4ox5uSWFmVWpQPk5LmYFES51XTeucn + JJCeWJKanZpakFoEk5Xh4FCS4H0YCdQoWJSanlqRlplTgpBm4uAEGc4DNPwCSA1vcUFibnFm + OkT+FKOilDjvSZCEAEgiozQPrheWmF4xigO9IgzRzgNManDdr4AGMwEN3semCzK4JBEhJdXA + GHp8fk98g4VP/N0Hu7KnN0Rz2HyNMI8VMebzP6P7+FCUwO05pvuYrfUsDwRVS0lu+iT8NXTG + qb+102/Wnkp4fexyBf9rIfskaQu7ozMM/rt9ZbFzU54T8slqouoh5oLJ92ZynH938fgUla5r + bVcZbiv9u1L2xnFR2L1lTuq/Hq9lep9QOmHvSyWW4oxEQy3mouJEAIKr8r0nAwAA +Cc: Tomi Ollila , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Feb 2012 04:43:19 -0000 + +Quoth David Bremner on Feb 03 at 8:50 pm: +> On Mon, 30 Jan 2012 18:01:15 +0200, Jani Nikula wrote: +> > On Jan 30, 2012 4:38 PM, "Tomi Ollila" wrote: +> > > +> > > > + +> > > > +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8. +> > > > + Tabs should be only at the beginning of the line. +> > > +> > > So, after initial indentation (with tabs) there should not be further +> > > tabs? We'll be using the former instead of the latter in these 2 below? +> +> Ah, I only meant to explain what whitespace-mode complains about, namely +> +> x=1; +> +> as opposed to +> +> x=1; +> +> I'm not sure it's that important, but apparently if it stays in the +> style guide it needs rewording. + +Any indentation style this difficult to explain can't be a good idea. +How about, + +* Indent is 4 spaces with mixed tab/spaces and a tab width of 8. + (Specifically, a line should begin with zero or more tabs followed + by fewer than eight spaces.) -- 2.26.2