From 885455c441f018bb93246951c7f1e975b863839f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 4 Feb 2012 10:28:23 +0200 Subject: [PATCH] Re: [PATCH 1/2] test: add check for filename argument for test_expect_equal_file --- 0d/746fa8416f28b07d0f5a3bcdc7191d38a05724 | 73 +++++++++++++++++++++++ 1 file changed, 73 insertions(+) create mode 100644 0d/746fa8416f28b07d0f5a3bcdc7191d38a05724 diff --git a/0d/746fa8416f28b07d0f5a3bcdc7191d38a05724 b/0d/746fa8416f28b07d0f5a3bcdc7191d38a05724 new file mode 100644 index 000000000..f65e25d5b --- /dev/null +++ b/0d/746fa8416f28b07d0f5a3bcdc7191d38a05724 @@ -0,0 +1,73 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 27A1B431FAF + for ; Sat, 4 Feb 2012 00:28:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id YUuSoaUIox+N for ; + Sat, 4 Feb 2012 00:28:25 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id 721F9431FAE + for ; Sat, 4 Feb 2012 00:28:25 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id 8464A68055; Sat, 4 Feb 2012 10:28:23 +0200 (EET) +From: Tomi Ollila +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: add check for filename argument for + test_expect_equal_file +In-Reply-To: <87sjishv3e.fsf@gmail.com> +References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com> + <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com> + <87zkd1p12c.fsf@servo.finestructure.net> <87sjishv3e.fsf@gmail.com> +User-Agent: Notmuch/0.11+7~gf38bc44 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 04 Feb 2012 08:28:26 -0000 + +On Fri, 03 Feb 2012 18:04:05 +0400, Dmitry Kurochkin wrote: +> On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins wrote: +> > Hey, Dmitry. I'm so sorry I sent my last email on your original patch +> > before I saw this new series. I do now like your original proposal +> > better, since it shows the diff based the names the caller provides, +> > which I now agree is probably the clearest and most robust solution. +> > The second patch in this series could still go through, though, no +> > matter what version of the change to test_expect_equal_file we go with. +> > +> +> Actually, we can do both: check file name for consistent diff order +> (from expected to actual) and use file names that the caller provides. +> +> What do you think? + ++1 + +> Regards, +> Dmitry + +Tomi -- 2.26.2