From 87b5cd13bde82ca3ea9335bb6785c2edf59f0a1c Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Mon, 9 Apr 2012 18:57:00 +0100 Subject: [PATCH] Re: [PATCH 2/8] emacs: update tag-completion function --- 13/a030068502df6d8d9627c22ac57cc6b8104e84 | 117 ++++++++++++++++++++++ 1 file changed, 117 insertions(+) create mode 100644 13/a030068502df6d8d9627c22ac57cc6b8104e84 diff --git a/13/a030068502df6d8d9627c22ac57cc6b8104e84 b/13/a030068502df6d8d9627c22ac57cc6b8104e84 new file mode 100644 index 000000000..b478e31a0 --- /dev/null +++ b/13/a030068502df6d8d9627c22ac57cc6b8104e84 @@ -0,0 +1,117 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2574B403E35 + for ; Mon, 9 Apr 2012 10:56:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id XPg0uc9rRnIz for ; + Mon, 9 Apr 2012 10:56:50 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0EF0A403E33 + for ; Mon, 9 Apr 2012 10:56:50 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1SHIpX-00073N-DP; Mon, 09 Apr 2012 18:56:45 +0100 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1SHIpX-0003Sn-3G; Mon, 09 Apr 2012 18:56:43 +0100 +From: Mark Walters +To: Jameson Graef Rollins , + Notmuch Mail +Subject: Re: [PATCH 2/8] emacs: update tag-completion function +In-Reply-To: <1333845338-22960-3-git-send-email-jrollins@finestructure.net> +References: <1333354853-25729-1-git-send-email-jrollins@finestructure.net> + <1333845338-22960-1-git-send-email-jrollins@finestructure.net> + <1333845338-22960-2-git-send-email-jrollins@finestructure.net> + <1333845338-22960-3-git-send-email-jrollins@finestructure.net> +User-Agent: Notmuch/0.12+111~g5c30f66 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 09 Apr 2012 18:57:00 +0100 +Message-ID: <878vi4n5zn.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 9d7257ed3ba7a2f97c8fe0802f6e8fd0 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 09 Apr 2012 17:56:51 -0000 + +On Sun, 08 Apr 2012, Jameson Graef Rollins wrote: +> "search-tags" is deprecated, so we move to the more modern and +> supported "search --output=tags". +> --- +> emacs/notmuch-tag.el | 2 +- +> 1 files changed, 1 insertions(+), 1 deletions(-) +> +> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el +> index 81b4b00..5240d13 100644 +> --- a/emacs/notmuch-tag.el +> +++ b/emacs/notmuch-tag.el +> @@ -59,7 +59,7 @@ the messages that were tagged" +> (with-output-to-string +> (with-current-buffer standard-output +> (apply 'call-process notmuch-command nil t +> - nil "search-tags" search-terms))) +> + nil "search" "--output=tags" search-terms))) + +Perhaps make this + + nil "search" "--output=tags" "--exclude=false" search-terms))) + +to fix the existing bug that if the message is excluded the completion +can get confused. Or I can submit that separately if you prefer. + +Best wishes + +Mark + +> "\n+" t)) +> +> (defun notmuch-select-tag-with-completion (prompt &rest search-terms) +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2