From 879cbc918d1cc7a97994c94e1078517f38deddb8 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Mon, 4 Jun 2012 07:10:03 +0000 Subject: [PATCH] Re: [PATCH 1/4] test: Add broken test for tag synchronization on files delivered to new/ --- f9/bc883d9a83cf4843246380d4460088511b1e4a | 116 ++++++++++++++++++++++ 1 file changed, 116 insertions(+) create mode 100644 f9/bc883d9a83cf4843246380d4460088511b1e4a diff --git a/f9/bc883d9a83cf4843246380d4460088511b1e4a b/f9/bc883d9a83cf4843246380d4460088511b1e4a new file mode 100644 index 000000000..016988117 --- /dev/null +++ b/f9/bc883d9a83cf4843246380d4460088511b1e4a @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 9D475431FB6 + for ; Mon, 4 Jun 2012 00:10:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ygikBYOptkdx for ; + Mon, 4 Jun 2012 00:10:07 -0700 (PDT) +Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com + [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id F0376431FAF + for ; Mon, 4 Jun 2012 00:10:06 -0700 (PDT) +Received: by vbbfc26 with SMTP id fc26so3923405vbb.26 + for ; Mon, 04 Jun 2012 00:10:06 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type:x-gm-message-state; + bh=9p4y8LO8kpr9PRjACrAQxpYm/jbecmjjZGGSovzc23M=; + b=lZ3mfDYdE8VnpQl8eIRCDgeOw9wloPny8eQo4f2E2BQwVjQ5EkHhz3PeOJjhoxyxDL + KFKfPsrZfBkgR3vXkDbwRKs00QmFe5/fGzJqFXHMeer0C2RpQ6FyGvqdp1ibLjdUB0Rn + y1yfCq8f6OaGYje1RGjUNUY3AnwORr8uoUte/j/D2/mlRr6jgRYD8VUs5fJAIgaNIAaJ + JeRqoqcpzg5hd26x6cYTBZwhQk9Gjmw0i5rnoukibBqPL9i0moXUhOTJHK18GLQSRz5M + CmDXqEKZ3PbuLSBtorpI1hdNO8AsssFCWvAKBGi3/AIcKBPIlOl3hfd4iBJVONoif9U5 + 0G4A== +Received: by 10.52.94.36 with SMTP id cz4mr10025053vdb.10.1338793805963; + Mon, 04 Jun 2012 00:10:05 -0700 (PDT) +Received: from localhost (nikula.org. [92.243.24.172]) + by mx.google.com with ESMTPS id g10sm16106772vdk.2.2012.06.04.00.10.04 + (version=SSLv3 cipher=OTHER); Mon, 04 Jun 2012 00:10:05 -0700 (PDT) +From: Jani Nikula +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/4] test: Add broken test for tag synchronization on + files delivered to new/ +In-Reply-To: <1338742656-11640-2-git-send-email-amdragon@mit.edu> +References: <1338742656-11640-1-git-send-email-amdragon@mit.edu> + <1338742656-11640-2-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.13+9~ga1668d0 (http://notmuchmail.org) Emacs/23.1.1 + (i686-pc-linux-gnu) +Date: Mon, 04 Jun 2012 07:10:03 +0000 +Message-ID: <87k3znr1ro.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQmBz6Lh3AFYtzMQ8ujHzqQiAhk/BGFkmQNzzLORvoJSs6jMuCjpGKXqA42Wtx6LMGfHukzw +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 04 Jun 2012 07:10:07 -0000 + +On Sun, 03 Jun 2012, Austin Clements wrote: +> Currently, notmuch new only synchronizs maildir flags to tags for + ++e to synchronizs. + +> files that have an "info" part. However, in maildir, new mail doesn't +> gain the info part until it moves from new/ to cur/. Hence, even +> though mail in new/ doesn't have an info part, it is still a maildir +> message and thus has maildir flags (though none of them set). +> +> The most visible effect of not synchronizing maildir flags for +> messages in new/ is that newly delivered messages don't get the unread +> tag (unless it is assigned by some other mechanism, like new.tags). +> +> This patch does *not* modify the test for messages in cur/ that do not +> have an "info" part. Unlike a message in new/, a message in cur/ +> without an info part is no longer a maildir message, and thus +> shouldn't be subject to maildir flag synchronization. +> --- +> test/maildir-sync | 10 ++++++++++ +> 1 file changed, 10 insertions(+) +> +> diff --git a/test/maildir-sync b/test/maildir-sync +> index d72ec07..6360fd2 100755 +> --- a/test/maildir-sync +> +++ b/test/maildir-sync +> @@ -166,4 +166,14 @@ add_message [subject]='"Non-compliant maildir info"' [dir]=cur [filename]='non-c +> notmuch tag +unread +draft -flagged subject:"Non-compliant maildir info" +> test_expect_equal "$(cd $MAIL_DIR/cur/; ls non-compliant*)" "non-compliant-maildir-info:2,These-are-not-flags-in-ASCII-order-donottouch" +> +> +test_begin_subtest "Files in new/ get default synchronized tags" +> +test_subtest_known_broken +> +OLDCONFIG=$(notmuch config get new.tags) +> +notmuch config set new.tags test +> +add_message [subject]='"File in new/"' [dir]=new [filename]='file-in-new' +> +notmuch config set new.tags $OLDCONFIG +> +notmuch search 'subject:"File in new"' | notmuch_search_sanitize > output +> +test_expect_equal "$(< output)" \ +> +"thread:XXX 2001-01-05 [1/1] Notmuch Test Suite; File in new/ (test unread)" +> + +> test_done +> -- +> 1.7.10 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2