From 8724cfb756bcbe00ff2bfcbf9516fff6865769d6 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 30 Mar 2013 16:21:19 +0200 Subject: [PATCH] [PATCH v2 0/3] cli: mail-followup-to support --- 60/abc483c7593164d43380a44b6fd08e31e5721e | 101 ++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 60/abc483c7593164d43380a44b6fd08e31e5721e diff --git a/60/abc483c7593164d43380a44b6fd08e31e5721e b/60/abc483c7593164d43380a44b6fd08e31e5721e new file mode 100644 index 000000000..f6a63a4e6 --- /dev/null +++ b/60/abc483c7593164d43380a44b6fd08e31e5721e @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 64005431FC2 + for ; Sat, 30 Mar 2013 07:21:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id IEu5sGCEo63p for ; + Sat, 30 Mar 2013 07:21:30 -0700 (PDT) +Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com + [209.85.217.171]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 95C9E431FBF + for ; Sat, 30 Mar 2013 07:21:30 -0700 (PDT) +Received: by mail-lb0-f171.google.com with SMTP id v10so931269lbd.16 + for ; Sat, 30 Mar 2013 07:21:29 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=x-received:from:to:cc:subject:date:message-id:x-mailer + :x-gm-message-state; + bh=63gd+yA0gZ7HnAnTpJ9Ya6WyVxGA6ghaM9DVthrNHGw=; + b=E1uzCxMv9VRa4J6RE/rG4dfsSxNe0kDGVR/+kwH11GtOh+QOxya5qGK+P22pRofevE + mVM3tMmsEGAQt9t9rmnkrzNeQFdLe1RakpBxpYe8p39C/Cui39gus17j3p9gQ8WEe3/L + V/bZtilNbRKTu6PpkXN8nzmK+00Ios710Ju7x8hYlzL7ZJTFVCRkjx0ZQNKXPVskdqD9 + hucWRhs57wU0zyv1K+rCGJUcui/ab7NrTzEYgbsm55wUWElD3VKjlNTIdEWdBP0M2gvu + eV6Susj1IP58RYRlR+x2uTk4xLMB8vYWzR3Bn8NfRE00OY9eBLqbpTcyajm/9lNQbMj1 + yHRw== +X-Received: by 10.112.46.231 with SMTP id y7mr2932467lbm.128.1364653288946; + Sat, 30 Mar 2013 07:21:28 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id l1sm2667834lbn.8.2013.03.30.07.21.27 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 30 Mar 2013 07:21:27 -0700 (PDT) +From: Jani Nikula +To: notmuch@notmuchmail.org +Subject: [PATCH v2 0/3] cli: mail-followup-to support +Date: Sat, 30 Mar 2013 16:21:19 +0200 +Message-Id: +X-Mailer: git-send-email 1.7.10.4 +X-Gm-Message-State: + ALoCoQke1uRIvLEJ3eSLao7M6g3xqyjCZThVycaB4Vwgj9H3w3YHqyf2ecQ0A1XtQnsS6jgUe5+N +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 30 Mar 2013 14:21:31 -0000 + +This is v2 of [1], rebased against master and with a better commit +message for patch 1/3. Patch 1/3 is trivial cleanup and IMO could just +be merged. There was debate on the actual stuff 2/3 and 3/3 [2]. + +I don't think adding a --reply-to=list option to notmuch reply is a good +idea. We should just do the right thing and keep the cli simple. Perhaps +we should drop the configuration (patch 2/3) altogether, and just +support mail-followup-to? + +Or, perhaps notmuch reply should return *all* options in json, and let +the UI decide. Above all, let the UI change the reply style while +editing the reply. I'd probably like this approach most, more than these +patches, but I don't have the time to do it. + +Here are the patches anyway; perhaps they could be an intermediate step, +or just a reference for anyone willing to do the above. + + +BR, +Jani. + + +[1] id:5eaa3acc22ee5513bdce5ab931b7a79ade880e06.1362254104.git.jani@nikula.org +[2] id:20130303120745.GA4884@hili.localdomain + +Jani Nikula (3): + cli: config: remove unnecessary braces from if blocks + cli: add reply.honor_followup_to configuration option + cli: support Mail-Followup-To: in notmuch reply + + notmuch-client.h | 7 +++++++ + notmuch-config.c | 56 ++++++++++++++++++++++++++++++++++++++++++------------ + notmuch-reply.c | 25 ++++++++++++++++++++++-- + 3 files changed, 74 insertions(+), 14 deletions(-) + +-- +1.7.10.4 + -- 2.26.2