From 83372ff8d4830d107baa478bdcbadab60d813424 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Wed, 31 Oct 2012 22:48:14 +0200 Subject: [PATCH] Re: [PATCH] emacs: Function to query the list of labels from a thread-id --- 0b/710d0c21fb6f3101a117f248452b42946d801a | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 0b/710d0c21fb6f3101a117f248452b42946d801a diff --git a/0b/710d0c21fb6f3101a117f248452b42946d801a b/0b/710d0c21fb6f3101a117f248452b42946d801a new file mode 100644 index 000000000..84ad3ad01 --- /dev/null +++ b/0b/710d0c21fb6f3101a117f248452b42946d801a @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 05BE9431FBD + for ; Wed, 31 Oct 2012 13:48:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 3tcupW1Nn-Ku for ; + Wed, 31 Oct 2012 13:48:20 -0700 (PDT) +Received: from mail-la0-f53.google.com (mail-la0-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 50F94431FBC + for ; Wed, 31 Oct 2012 13:48:20 -0700 (PDT) +Received: by mail-la0-f53.google.com with SMTP id l5so1450097lah.26 + for ; Wed, 31 Oct 2012 13:48:17 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type:x-gm-message-state; + bh=j12EOJL0vIWN/ehJPs8Ar5OXGPz0blgpJ5xAUAxziig=; + b=iktVGieyWYRmmLCMwSxwiooou0sZzbczqDI64/o1+r8QL54GWBanrNDRL29Z/TsbRU + yLhpv1T3T6szJKNnI+171YxAD/bDJa5FZQHVhpHYYH782K4ljapnkqJjTphU+D/O86LR + CfJYqZ82PO6ri6Uop65GdSc5Om0JjWYe+aXe4yHQKbAsiNhBhrfDh92CnW0yrOQ53Y9D + z+sg/fFTSq2KVJry4kyDSE2F7uTZDEwcILppkDO7ZVP9SqHTbtH6ufQOMf6W9IfOpEBP + BQ1063K7z3Owp+oBKOrt5MGfIpCtyTeIXbgUl7e5ifDHXk6cB3bQkuMnr8UO5Gq+6fZ0 + rKyA== +Received: by 10.112.100.170 with SMTP id ez10mr742459lbb.25.1351716497406; + Wed, 31 Oct 2012 13:48:17 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id nr2sm1640401lab.5.2012.10.31.13.48.15 + (version=SSLv3 cipher=OTHER); Wed, 31 Oct 2012 13:48:16 -0700 (PDT) +From: Jani Nikula +To: David Bremner , + Damien Cassou , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Function to query the list of labels from a + thread-id +In-Reply-To: <87objibex1.fsf@zancas.localnet> +References: <1351451478-11792-1-git-send-email-damien.cassou@gmail.com> + <87390v8z52.fsf@nikula.org> <87objibex1.fsf@zancas.localnet> +User-Agent: Notmuch/0.14+76~gef5e8d1 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Wed, 31 Oct 2012 22:48:14 +0200 +Message-ID: <87obji74hd.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQlJc2iPNW2vhGoQjJdRaaf7BC3pOjuBvJ2/q2E/PCuE0Y6BRGM8fEtSlsvYNyUcX3BxFdp/ +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 31 Oct 2012 20:48:21 -0000 + +On Wed, 31 Oct 2012, David Bremner wrote: +> Jani Nikula writes: +> +>> Hi Damien, please send this patch as part of the series adding +>> notmuch-labeler. Out of context, without adding any users of the +>> function, it's a bit difficult to evaluate. +> +> For what it's worth (and I'm definitely not claiming any kind final word +> here) I did tell Damien that he was welcome to send pre-requisite +> patches in a seperate series. Of course, if you feel like you can't +> really review what's there (or it's just too much work), that's your +> call. + +I don't disagree with sending pre-requisite patches first. And I am +definitely not asking to polish all of the follow up work at once. I +should have made myself more clear about that. But I do think it would +be helpful to see what the added code will be used for. We may be able +to provide better and more productive review of the big picture, instead +of focusing on the details of the small snippet here. + +BR, +Jani. -- 2.26.2