From 82a36fe3c29842d6db5d63ef182f095f464d25e9 Mon Sep 17 00:00:00 2001 From: Ethan Glasser-Camp Date: Thu, 18 Oct 2012 20:29:29 +2000 Subject: [PATCH] Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to `notmuch-show-toggle-visibility-headers' --- 28/aa5fb005908b893398c9e852ec49e93035c617 | 80 +++++++++++++++++++++++ 1 file changed, 80 insertions(+) create mode 100644 28/aa5fb005908b893398c9e852ec49e93035c617 diff --git a/28/aa5fb005908b893398c9e852ec49e93035c617 b/28/aa5fb005908b893398c9e852ec49e93035c617 new file mode 100644 index 000000000..31381877c --- /dev/null +++ b/28/aa5fb005908b893398c9e852ec49e93035c617 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ED794431FBF + for ; Wed, 17 Oct 2012 17:29:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id HZZv2YftqtUJ for ; + Wed, 17 Oct 2012 17:29:33 -0700 (PDT) +Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com + [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2EF20431FB6 + for ; Wed, 17 Oct 2012 17:29:33 -0700 (PDT) +Received: by mail-vc0-f181.google.com with SMTP id n11so8987857vch.26 + for ; Wed, 17 Oct 2012 17:29:32 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=+GcfYylpklVrJBkoGwx/l9li2CYCxf1P0fjgt9+7YAU=; + b=w791W0C227rWO1+Qq6jlHrEY2E4OKx5eMQOGArn9+yN6Svk9ZaX0hvutCjO3m2TZUA + I39j6kq/EQDUavBPcffiZPJ6fT34JAeF9ZuyiXnDgKhBPsyEldm6XORLbttQf/Bt4DrW + +xnhT2Z7Nh7tOHMGBkBLazdpBF1SbW4YGnHSnGLd43l+41t7tC105xSa/unzqVNoUNIN + dYZXnzzuYsB3wEDnhlIO1BjSolYsi6IpkC2D3tWGS942AbisWo0U8vuNgeQVUFvNqDpx + E4C0KJ3UikMdnvTv4HctPBTTnaczbuLrToJVha91uyblj46+uIf+IUNyETGQVNuaRytL + IVKQ== +Received: by 10.52.68.19 with SMTP id r19mr1546521vdt.29.1350520172368; + Wed, 17 Oct 2012 17:29:32 -0700 (PDT) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id y15sm3703372vdg.22.2012.10.17.17.29.31 + (version=TLSv1/SSLv3 cipher=OTHER); + Wed, 17 Oct 2012 17:29:31 -0700 (PDT) +From: Ethan Glasser-Camp +To: Ethan Glasser-Camp , + Pieter Praet , Notmuch Mail +Subject: Re: [PATCH v2 3/7] emacs: rename `notmuch-show-toggle-headers' to + `notmuch-show-toggle-visibility-headers' +In-Reply-To: <87k3uv9xuo.fsf@betacantrips.com> +References: <1327469139-1968-1-git-send-email-pieter@praet.org> + <1329936214-30959-3-git-send-email-pieter@praet.org> + <87k3uv9xuo.fsf@betacantrips.com> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 17 Oct 2012 20:29:29 -0400 +Message-ID: <877gqo8vx2.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 18 Oct 2012 00:29:37 -0000 + +Ethan Glasser-Camp writes: + +> This patch, and its predecessors, all look great to me. + +But a note: many of the first lines in your commit messages ("{show, +hide} message headers") contain tabs. I hate tabs. Is this intentional? +I have noticed it on other patches you've sent (such as +id:"1330122640-18895-6-git-send-email-pieter@praet.org" and +id:"1330122640-18895-7-git-send-email-pieter@praet.org"). + +Ethan -- 2.26.2