From 7f190232bf109f87df57b98d224f8923407dd552 Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Mon, 16 Apr 2012 23:51:12 +0200 Subject: [PATCH] Re: [PATCH 1/7] Split notmuch_database_close into two functions --- 22/a9eaebe81a6f219327ffbfb7b956574d143cfc | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 22/a9eaebe81a6f219327ffbfb7b956574d143cfc diff --git a/22/a9eaebe81a6f219327ffbfb7b956574d143cfc b/22/a9eaebe81a6f219327ffbfb7b956574d143cfc new file mode 100644 index 000000000..8ec3d8a24 --- /dev/null +++ b/22/a9eaebe81a6f219327ffbfb7b956574d143cfc @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BB6A9431FAF + for ; Mon, 16 Apr 2012 14:51:18 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id U6rZk9h7-Koz for ; + Mon, 16 Apr 2012 14:51:16 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 69620431FAE + for ; Mon, 16 Apr 2012 14:51:16 -0700 (PDT) +Received: from mail.jade-hamburg.de (unknown [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id C9F465833F2 + for ; Mon, 16 Apr 2012 23:51:14 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 14C98DF2A2; Mon, 16 Apr 2012 23:51:14 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (unknown [10.1.1.153]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) (Authenticated sender: teythoon) + by mail.jade-hamburg.de (Postfix) with ESMTPSA id 14F4ADF2A0; + Mon, 16 Apr 2012 23:51:13 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1SJtpI-00052m-IR; Mon, 16 Apr 2012 23:51:12 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +From: Justus Winter <4winter@informatik.uni-hamburg.de> +User-Agent: alot/0.3+ +To: Mark Walters , notmuch@notmuchmail.org +References: + <1332291311-28954-1-git-send-email-4winter@informatik.uni-hamburg.de> + <1332291311-28954-2-git-send-email-4winter@informatik.uni-hamburg.de> + <87fwcopu5g.fsf@qmul.ac.uk> +In-Reply-To: <87fwcopu5g.fsf@qmul.ac.uk> +Message-ID: <20120416215112.15615.94985@thinkbox.jade-hamburg.de> +Subject: Re: [PATCH 1/7] Split notmuch_database_close into two functions +Date: Mon, 16 Apr 2012 23:51:12 +0200 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 16 Apr 2012 21:51:18 -0000 + +Quoting Mark Walters (2012-03-31 19:17:15) +> Secondly, I think the patch series could be made clearer and easier to +> review. If you do it in three steps +> = + +> 1) change of notmuch_database_close to notmuch_database_destroy (just +> the function name change) +> 2) split the new notmuch_database_destroy into two as in the current +> first patch +> 3) Make any changes (if there are any) of notmuch_database_destroy to +> notmuch_database_close. +> = + +> The advantage is that the first change is easy to test (essentially does +> it build) and then changes from notmuch_database_destroy to +> notmuch_database_close in step 3 are explicit rather than the current +> situation where we need to grep the code to see if some instances of +> notmuch_database_close were not changed to notmuch_database_destroy. + +I don't buy it. The patch series first touches the library and +documentation and the lib compiles fine. The next patch updates the +cli tools, all of them compile fine afterwards. + +Every patch addresses the issue component wise, this seems rather +natural for me. + +Cheers, +Justus -- 2.26.2