From 7d5959758c344171c949622456db538a2b4938b6 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Tue, 8 Oct 2013 08:56:30 +0100 Subject: [PATCH] Re: [PATCH 00/11] Fix search tagging races --- ed/fc1a179e48d65756a0e9230f294e327222246d | 115 ++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 ed/fc1a179e48d65756a0e9230f294e327222246d diff --git a/ed/fc1a179e48d65756a0e9230f294e327222246d b/ed/fc1a179e48d65756a0e9230f294e327222246d new file mode 100644 index 000000000..123953ee6 --- /dev/null +++ b/ed/fc1a179e48d65756a0e9230f294e327222246d @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 01447431FAF + for ; Tue, 8 Oct 2013 00:56:39 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yt2FGVfMJXqx for ; + Tue, 8 Oct 2013 00:56:33 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 14C77431FAE + for ; Tue, 8 Oct 2013 00:56:33 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VTS9f-0003BG-A0; Tue, 08 Oct 2013 08:56:31 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VTS9f-0000Yy-0h; Tue, 08 Oct 2013 08:56:31 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] Fix search tagging races +In-Reply-To: <1381185201-25197-1-git-send-email-amdragon@mit.edu> +References: <1381185201-25197-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+334~gafd5c6a (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 08 Oct 2013 08:56:30 +0100 +Message-ID: <87ob70kxg1.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: f34cb0042d00c0f72f1fc0c89e44afb0 (of first 20000 bytes) +X-SpamAssassin-Score: 0.6 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.6 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.4 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 08 Oct 2013 07:56:40 -0000 + + +Hello + +It's great that this might finally get done. But there is one problem +currently. + +If you open a large search buffer and then do *- it will die as the +tagging routine runs notmuch search to find a completion-list for the +tag. (it runs notmuch search --output=tags ) + +We could just return all tags in this case. Or we could do something +like the series +id:1354263691-19715-1-git-send-email-markwalters1009@gmail.com +which makes completion happen based on the tags visible to the user, not +the tags actually in the database. + +There is also a little discussion of this in my earlier attempt at +fixing this: eg id:87mwy4smad.fsf@qmul.ac.uk + +Best wishes + +Mark + +On Mon, 07 Oct 2013, Austin Clements wrote: +> I was hacking on undo support for notmuch-emacs and sort of +> accidentally wrote this instead. This series fixes a set of +> well-known races where tagging from search-mode unexpectedly affects +> messages that arrived after the search was performed (and hence the +> user doesn't know they're tagging them). We've attacked this a few +> times before, but have always run up against something that was +> missing. It turns out the pieces are finally all in place. +> +> The first five patches just clean various things up in preparation. +> Patches 6 and 7 add support for tagging large queries, which would +> otherwise become a problem when later patches start using explicit +> message ID-based queries for tagging. The remaining four patches +> actually fix the search tagging races using explicit message ID-based +> queries. +> +> It's a fairly long series, but none of the patches are very big. +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2