From 7b3dc3381b6c39aeea9890b9e238f8d307c10814 Mon Sep 17 00:00:00 2001 From: Ethan Glasser-Camp Date: Tue, 16 Oct 2012 13:12:04 +2000 Subject: [PATCH] Re: [PATCH 1/2] test: emacs mailto: URI handling --- 10/73975383ce6d1a368263667236ed900024194b | 93 +++++++++++++++++++++++ 1 file changed, 93 insertions(+) create mode 100644 10/73975383ce6d1a368263667236ed900024194b diff --git a/10/73975383ce6d1a368263667236ed900024194b b/10/73975383ce6d1a368263667236ed900024194b new file mode 100644 index 000000000..d86d100de --- /dev/null +++ b/10/73975383ce6d1a368263667236ed900024194b @@ -0,0 +1,93 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A0403431FB6 + for ; Mon, 15 Oct 2012 10:12:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id KoDjMDmB6xyX for ; + Mon, 15 Oct 2012 10:12:08 -0700 (PDT) +Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com + [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A10C5431FAE + for ; Mon, 15 Oct 2012 10:12:08 -0700 (PDT) +Received: by mail-qc0-f181.google.com with SMTP id x40so4820367qcp.26 + for ; Mon, 15 Oct 2012 10:12:08 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type; + bh=kGBkaDph+R6AE03TuTZwYu6VSGhYX9zXYOtvflAl4dg=; + b=wGKBwVe5qezSjb8c2WTwQH9kagDllaJZS89NmtNSvp/Teyk4b+BQ3i1Zx516KGOr+4 + 9PDu9+7aF+/4kdP0kMxWjj9FSTo0XId2+Ntz5c9QBfElL1oYcpx9p7AzekvvDHXIN4bB + jFyxq7ALRZRrl2FmV1ybDJX9jiCyBNW7BVBkLvKGrBvSebJo6XUldWMB8OvnItaRDHtL + ipG/LpmK1jT7VQIL4FeH1HRWQjjAKncnEKkq/viQ7HXl6oAkcXSoto+gS1xhfW0qq49R + 0ooey+mOmqFJyqsN6N3P+peh5T9keX/9b+dw9AVuoH6RqRI4T1zm0wyGG/iRpqbJruVY + IzWg== +Received: by 10.224.31.204 with SMTP id z12mr12704102qac.32.1350321127827; + Mon, 15 Oct 2012 10:12:07 -0700 (PDT) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id hk10sm7707580qab.22.2012.10.15.10.12.05 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 15 Oct 2012 10:12:06 -0700 (PDT) +From: Ethan Glasser-Camp +To: Jameson Graef Rollins , + Notmuch Mail +Subject: Re: [PATCH 1/2] test: emacs mailto: URI handling +In-Reply-To: <1327865624-7673-1-git-send-email-jrollins@finestructure.net> +References: <1327865624-7673-1-git-send-email-jrollins@finestructure.net> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 15 Oct 2012 13:12:04 -0400 +Message-ID: <877gqracd7.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 15 Oct 2012 17:12:10 -0000 + +Jameson Graef Rollins writes: + +> This adds a test for proposed rfc6068 "mailto:" URI handling. The +> proposed function would be called 'notmuch-mua-mailto'. The test +> provides an example mailto: string that should test some subset of the +> rfc6068 specification: http://tools.ietf.org/html/rfc6068 + +Hi! Just going through the patch queue. This test, at least, looks +sane, so why not apply it? + +As for the mailto: handler itself, you wrote in +id:"87vcin2fo6.fsf@servo.finestructure.net" that you would add something +to the next version, thereby implying that there would be a next +version. Do you still intend to release such a new version soon? I would +love to review it. This version looks fine to me, with one minor concern. + +> + ;; FIXME: need to decode all html encodings in uri. +> + (mailto (replace-regexp-in-string "&" "&" mailto)) + +This is odd. Shouldn't the navigator be decoding all that stuff while +parsing, before you even get to it? How often do you get mailto links +with & in them? You obviously wouldn't have put it in there if it +weren't necessary. + +I would be +1 on merging this patch or the next version. + +Ethan -- 2.26.2