From 7ad5de61c8dbb4c6716626fd73230e4d4b2f9786 Mon Sep 17 00:00:00 2001 From: Ethan Glasser-Camp Date: Tue, 6 Nov 2012 23:12:39 +1900 Subject: [PATCH] Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to know --- 4e/f1b571b6dd83e7f08794f5f829da3c019b6ced | 86 +++++++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 4e/f1b571b6dd83e7f08794f5f829da3c019b6ced diff --git a/4e/f1b571b6dd83e7f08794f5f829da3c019b6ced b/4e/f1b571b6dd83e7f08794f5f829da3c019b6ced new file mode 100644 index 000000000..d927d70c7 --- /dev/null +++ b/4e/f1b571b6dd83e7f08794f5f829da3c019b6ced @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BE603431FB6 + for ; Mon, 5 Nov 2012 20:12:46 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Xdm7JVMHm1Oh for ; + Mon, 5 Nov 2012 20:12:45 -0800 (PST) +Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com + [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3D6F7431FAE + for ; Mon, 5 Nov 2012 20:12:45 -0800 (PST) +Received: by mail-vc0-f181.google.com with SMTP id n11so14243vch.26 + for ; Mon, 05 Nov 2012 20:12:44 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:in-reply-to:references:user-agent:date + :message-id:mime-version:content-type; + bh=LiFV/9cDsFRudng+09arYVzDkRAz+0YNQtpYFBXy+7w=; + b=ns1mapmLqXExWXAsFQvB7AU8L5MVYtFXg3yr4fFCc5wfE+gT68TJ5tBj3ycEmylWr0 + syIyuR034HuchIX2gu9OgqAm3Ci4Mn7tkTHDpb/dfBDmWK4cXkhM4UqnxKuwsvwIL6a8 + 2qzhGKDoeFpfESeDSewppxz1OTUY3ts5vh1CV5WcMPWr7ke5egtfa+zlQ+x8YXSx1eyW + U7ecRC7qYgXTulbr+RHqmO5f6WA9ovwtQh5YCxt6rZwvPxFHNuH3//U7Vw6U2UrJUs1s + z6iK/NLwAwgGYn3t4zHgajl03pYgP6PZvCcEAKyedee4T7KlR9Y7uEFsFx9HYHCdl9X8 + paaA== +Received: by 10.52.173.34 with SMTP id bh2mr10167796vdc.73.1352175164567; + Mon, 05 Nov 2012 20:12:44 -0800 (PST) +Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80]) + by mx.google.com with ESMTPS id zx18sm9362259veb.3.2012.11.05.20.12.43 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 05 Nov 2012 20:12:44 -0800 (PST) +From: Ethan Glasser-Camp +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] uncrustify.cfg: added 3 new types for uncrustify to + know +In-Reply-To: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi> +References: <1351865226-916-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Mon, 05 Nov 2012 23:12:39 -0500 +Message-ID: <87390nid3c.fsf@betacantrips.com> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 06 Nov 2012 04:12:46 -0000 + +Tomi Ollila writes: + +> Added FILE, notmuch_show_params_t and sprinter_t to be +> types when uncrustifying sources. This affect spacing +> when uncrustify is deciding for type declaration instead +> of binary multiplication operation. + +This looks good to me. If you had plenty of time and no more patches to +review, I'd prefer the slightly cleaner English: + +This affects how uncrustify puts spacing around pointers to these types, +since it can parse them as type declarations instead of binary +multiplication operations. + + +... but even suggesting this indicates I've moved past the bike shed and +into somebody else's kitchen. + +Ethan -- 2.26.2