From 79792b9b26d4a91367905a1f54d648ae866ee0d2 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Wed, 22 Feb 2012 23:46:12 +1700 Subject: [PATCH] Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and message-cite-original --- b5/e115b9f65515dc642bf31e5a104c66e4b06326 | 101 ++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 b5/e115b9f65515dc642bf31e5a104c66e4b06326 diff --git a/b5/e115b9f65515dc642bf31e5a104c66e4b06326 b/b5/e115b9f65515dc642bf31e5a104c66e4b06326 new file mode 100644 index 000000000..73a1591fd --- /dev/null +++ b/b5/e115b9f65515dc642bf31e5a104c66e4b06326 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1D884431FB6 + for ; Tue, 21 Feb 2012 22:46:17 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GlJc2Hj+4oIi for ; + Tue, 21 Feb 2012 22:46:16 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 398D8431FAE + for ; Tue, 21 Feb 2012 22:46:15 -0800 (PST) +Received: by lahd3 with SMTP id d3so9000294lah.26 + for ; Tue, 21 Feb 2012 22:46:12 -0800 (PST) +Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.152.102.237 + as permitted sender) client-ip=10.152.102.237; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of awg@xvx.ca designates + 10.152.102.237 as permitted sender) smtp.mail=awg@xvx.ca +Received: from mr.google.com ([10.152.102.237]) + by 10.152.102.237 with SMTP id fr13mr21997935lab.10.1329893172980 + (num_hops = 1); Tue, 21 Feb 2012 22:46:12 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.152.102.237 with SMTP id fr13mr18424909lab.10.1329893172915; + Tue, 21 Feb 2012 22:46:12 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.114.103 with HTTP; Tue, 21 Feb 2012 22:46:12 -0800 (PST) +X-Originating-IP: [96.52.216.56] +In-Reply-To: <20120217200017.GG5991@mit.edu> +References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca> + <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca> + <20120217200017.GG5991@mit.edu> +Date: Tue, 21 Feb 2012 23:46:12 -0700 +X-Google-Sender-Auth: WPQOsapDmpr1XIm2hqmD_xAGHBM +Message-ID: + +Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and + message-cite-original +From: Adam Wolfe Gordon +To: Austin Clements +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQlDjRefGRt6cLtC1ou4vELXCH9Uo7r45nhITIupi2PcZGBZdPe/IxnqIOphc+lai20B5H4a +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 22 Feb 2012 06:46:17 -0000 + +Hi Austin, + +A couple of quick notes below, just before I send the new version: + +On Fri, Feb 17, 2012 at 13:00, Austin Clements wrote: +> One of the biggest wins of using consistent JSON parsing settings is +> that this can be replaced with notmuch-show-mm-display-part-inline, +> which, as far as I can tell, accomplishes the same thing, but handles +> a lot of corner-cases that this doesn't (like crypto and charset +> conversion). + +This would be very desirable indeed, but after taking a stab at it, +I've discovered it's a really significant amount of work. The show +code relies on a bunch of buffer-local variables regarding crypto and +such, which are tricky to factor out into notmuch-lib. + +Do you think it's acceptable to leave this as future work? + +> Alternatively, notmuch-mua-get-quotable-parts could be +> notmuch-mua-insert-quotable-parts, which would probably simplify +> things a bit. =A0Your call. + +I've decided to leave this as get-quotable-parts. This is mostly my +personal preference to have a single function do the insertions when +possible, which I think makes the flow more obvious. + +> Is message-cite-original guaranteed to leave point in a reasonable +> place for this or should we create our own marker above (probably +> after the if re-search-backward..) and use it here to get point to the +> right place? + +It turns out it actually wasn't, which is why MML tags weren't getting +escaped twice. I've fixed this. -- 2.26.2