From 78d051f65d02d32a82f136a0e4f9c15dc8e813f1 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 16 Apr 2012 09:45:06 +2100 Subject: [PATCH] Re: [PATCH] lib: work around talloc_steal usage from C++ code --- 8c/0869090898445e2f54c44c324de45e18d562ce | 66 +++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 8c/0869090898445e2f54c44c324de45e18d562ce diff --git a/8c/0869090898445e2f54c44c324de45e18d562ce b/8c/0869090898445e2f54c44c324de45e18d562ce new file mode 100644 index 000000000..931b21105 --- /dev/null +++ b/8c/0869090898445e2f54c44c324de45e18d562ce @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A1EF5431FAF + for ; Sun, 15 Apr 2012 05:45:21 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SXJEy3YSMKLz for ; + Sun, 15 Apr 2012 05:45:17 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7A690431FAE + for ; Sun, 15 Apr 2012 05:45:17 -0700 (PDT) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) + (Exim 4.72) (envelope-from ) + id 1SJOpL-0008Rp-PS; Sun, 15 Apr 2012 09:45:16 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.77) + (envelope-from ) + id 1SJOpG-0004Ca-Fk; Sun, 15 Apr 2012 09:45:06 -0300 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] lib: work around talloc_steal usage from C++ code +In-Reply-To: <1334264259-17632-1-git-send-email-jani@nikula.org> +References: <1334264259-17632-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.12+104~gf9ad237 (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 15 Apr 2012 09:45:06 -0300 +Message-ID: <87k41htb8t.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Apr 2012 12:45:21 -0000 + +Jani Nikula writes: + +> Implicit typecast from 'void *' to 'T *' is okay in C, but not in +> C++. In talloc_steal, an explicit cast is provided for type safety in +> some GCC versions. Otherwise, a cast is required. Provide a template +> function for this to maintain type safety, and redefine talloc_steal +> to use it. + +pushed, + +d -- 2.26.2