From 780fa23bdc14424d5dc38c3d864fc744005bea1b Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Sat, 18 Feb 2012 19:22:07 +1700 Subject: [PATCH] Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and message-cite-original --- b9/2c1acdedafb04aa64449e87a6576ae78fb35fa | 132 ++++++++++++++++++++++ 1 file changed, 132 insertions(+) create mode 100644 b9/2c1acdedafb04aa64449e87a6576ae78fb35fa diff --git a/b9/2c1acdedafb04aa64449e87a6576ae78fb35fa b/b9/2c1acdedafb04aa64449e87a6576ae78fb35fa new file mode 100644 index 000000000..aba0da21c --- /dev/null +++ b/b9/2c1acdedafb04aa64449e87a6576ae78fb35fa @@ -0,0 +1,132 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17C82431FB6 + for ; Fri, 17 Feb 2012 18:22:10 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id JfwEsjjJqwNF for ; + Fri, 17 Feb 2012 18:22:09 -0800 (PST) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5F2C1431FAE + for ; Fri, 17 Feb 2012 18:22:09 -0800 (PST) +Received: by lahd3 with SMTP id d3so4645976lah.26 + for ; Fri, 17 Feb 2012 18:22:07 -0800 (PST) +Received-SPF: pass (google.com: domain of awg@xvx.ca designates 10.152.123.68 + as permitted sender) client-ip=10.152.123.68; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of awg@xvx.ca designates + 10.152.123.68 as permitted sender) smtp.mail=awg@xvx.ca +Received: from mr.google.com ([10.152.123.68]) + by 10.152.123.68 with SMTP id ly4mr8237667lab.13.1329531727932 + (num_hops = 1); Fri, 17 Feb 2012 18:22:07 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.152.123.68 with SMTP id ly4mr6879914lab.13.1329531727829; Fri, + 17 Feb 2012 18:22:07 -0800 (PST) +Sender: awg@xvx.ca +Received: by 10.112.90.20 with HTTP; Fri, 17 Feb 2012 18:22:07 -0800 (PST) +X-Originating-IP: [96.52.216.56] +In-Reply-To: <20120217200017.GG5991@mit.edu> +References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca> + <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca> + <20120217200017.GG5991@mit.edu> +Date: Fri, 17 Feb 2012 19:22:07 -0700 +X-Google-Sender-Auth: FxZHoDEOlYKfKKDBHysktGvvlKg +Message-ID: + +Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and + message-cite-original +From: Adam Wolfe Gordon +To: Austin Clements +Content-Type: text/plain; charset=ISO-8859-1 +Content-Transfer-Encoding: quoted-printable +X-Gm-Message-State: + ALoCoQnC4Wnr2Z5GwLVPvuX+ioA2RiG3XgCKSOVmiTkJ8hSCk5LevU3T0EOObbUvY1lIvZbCIJ9J +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 18 Feb 2012 02:22:10 -0000 + +On Fri, Feb 17, 2012 at 13:00, Austin Clements wrote: +> One general comment that affects a lot of things in this patch: I +> think you should use the same JSON parsing settings that +> notmuch-query-get-threads uses. =A0Besides consistency and more +> opportunities for code reuse, using lists instead of vectors for JSON +> arrays will simplify a lot of this code without any drawbacks. + +I pretty much agree. The only reason I stuck with alists was, as you +mention below, to be compatible with certain mail functions. Given the +things you've pointed out, I think the small hassle of making those +work with plists is worthwhile, so I'll give it a go. + +Clarification on a couple of things follow, otherwise I'll make all +these changes for the next version. + +>> + =A0 =A0 (goto-char (point-max))) +>> + +>> + =A0 =A0 =A0(let ((from (cdr (assq 'From original-headers))) +>> + =A0 =A0 =A0 =A0 (date (cdr (assq 'Date original-headers))) +>> + =A0 =A0 =A0 =A0 (start (point))) +>> + +>> + =A0 =A0 (insert "From: " from "\n") +>> + =A0 =A0 (insert "Date: " date "\n\n") +> +> Sorry; I'm having trouble following the diff. =A0What are the inserts +> for? + +The function message-cite-original cites an original message, which is +in the marked region. It assumes the headers of the original message +will be part of the marked region, but the only ones it actually uses +are From and Date. + +This could probably use a comment in the code. + +>> + =A0 =A0 (push-mark) +> +> It's unfortunate that message-cite-original depends on the mark. +> Since you're about to push the mark for the user anyway, maybe this +> should be a set-mark so that only one mark gets pushed? + +Probably the right thing to do. + +>> + =A0 =A0 (goto-char start) +>> + =A0 =A0 ;; Quote the original message according to the user's configur= +ed style. +>> + =A0 =A0 (message-cite-original)))) +> +> message-cite-original-without-signature? + +Perhaps it should be configurable (notmuch-reply-cite-function or +somesuch). I believe message-cite-original matches the behavior of the +old reply, which didn't strip signatures, but I don't have strong +feelings either way. + +>> + =A0(push-mark) +> +> Is message-cite-original guaranteed to leave point in a reasonable +> place for this or should we create our own marker above (probably +> after the if re-search-backward..) and use it here to get point to the +> right place? + +In my experience, it leaves the point at the end of the quoted region, +but the documentation doesn't make any guarantees. Probably safer to +set a marker. -- 2.26.2