From 76f6175cd5c200ac0fbc6ec0518f0e650835799f Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Thu, 29 Mar 2012 14:41:27 +1700 Subject: [PATCH] bug in emacs reply code for References headers --- fc/c00e1ba295120ac4baa319cccca56ba9895001 | 94 +++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 fc/c00e1ba295120ac4baa319cccca56ba9895001 diff --git a/fc/c00e1ba295120ac4baa319cccca56ba9895001 b/fc/c00e1ba295120ac4baa319cccca56ba9895001 new file mode 100644 index 000000000..ec423d85d --- /dev/null +++ b/fc/c00e1ba295120ac4baa319cccca56ba9895001 @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 131A7431FAF + for ; Wed, 28 Mar 2012 14:41:33 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id P8brLRVImu-g for ; + Wed, 28 Mar 2012 14:41:32 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id A9A98431FAE + for ; Wed, 28 Mar 2012 14:41:32 -0700 (PDT) +Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by earth-doxen-postvirus (Postfix) with ESMTP id 36A9B66E0186 + for ; Wed, 28 Mar 2012 14:41:32 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new +Received: from finestructure.net (DHCP-123-229.caltech.edu [131.215.123.229]) + (Authenticated sender: jrollins) + by earth-doxen-submit (Postfix) with ESMTP id 7BCEC66E00EF + for ; Wed, 28 Mar 2012 14:41:30 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 5643DB4; Wed, 28 Mar 2012 14:41:30 -0700 (PDT) +From: Jameson Graef Rollins +To: Notmuch Mail +Subject: bug in emacs reply code for References headers +User-Agent: Notmuch/0.12+75~gb2dcc3c (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 28 Mar 2012 14:41:27 -0700 +Message-ID: <87iphos8s8.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 28 Mar 2012 21:41:33 -0000 + +--=-=-= + +Hi, folks. I just wanted to make people aware of a bug in the new reply +code (new JSON reply format) on the current master. + +It appears that newlines are not placed after the References header is +inserted, which means that the User-Agent header gets concatenated at +the end of the References line, causing malformed References. I have +been able to get around this by adding the newline in manually in the +reply buffer. But it is easy to not notice, and the bug may destroy +subsequent threading. + +Adam Wolfe Gordon, the original author of the new JSON reply code, was +made aware of this on IRC and I believe he is looking into the issue. +In any event, those using master and the emacs UI should aware of this +issue. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPc4WHAAoJEO00zqvie6q8nawP/iDg+ftI26pwOeVGMUTkG3Z0 +MzFtF+ai+YRJA35wVzWBfm8NcFTaqxxulhPytXU8eiSYVW2SxFWh2mchn0/tufG5 +aO5xo5Nz6JPDm7Wz1v7yUumVp1wV+1TkkamdxnCC35LvhdPisNwtb/IiIUEAsL3P +qQXdrgeMAodIh8XiOEMoLdJkIFy7TW6ajclgiPi2BVDiju40obWeiRet/IxmjFH+ +6Op0je5WBsSyTZqre17n/mQSC5fDQS4VF/GdoX7r244/eIAZMPKGZitVc8hboomR +zxnNclPXaPgu0eWz0+6ADFe92K3q/8qUrSLdxjpE6q2U/kuqdjJhZvOO0RCioLYZ +v6EfGXwEdfcX/fW491b1QCuEW/aXBA/7jq6v5nExWtrROrWDpJkLUxuKj0mr6jlM +pYuC/cjqxRdGKFX1dpjkUo9b3to3W6K6mDhXuO8hod1XyL0KqFAE6Te19VR2bWLr +SO3/cALGK4/9Oj6PayZBO68VGQuejOI4AeZnFB4YB++k6fHb0c0cHVzLzptrk9sA +W4Cs2oA8iIQvoYWvy3dCia4BD0nhsmxjoiJnj+zT4WwUMH8OKtJqS/vx4Vy+izFP +wS8C1/UZXFwT8ebmBz6aND364gcCcOGdZZEwnYL8SmqYIl8qJ9G/gmkOkHKVSISP +1ppeFfWhXqPgqdQTIni+ +=Q7zY +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2