From 73622a9f40c1359713668ff769ac300b54854b1a Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 26 Dec 2012 10:34:19 +2000 Subject: [PATCH] Re: [PATCH 2/5] util: Function to parse boolean term queries --- 18/eac176f245826c46c80044ca4861244963f9da | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 18/eac176f245826c46c80044ca4861244963f9da diff --git a/18/eac176f245826c46c80044ca4861244963f9da b/18/eac176f245826c46c80044ca4861244963f9da new file mode 100644 index 000000000..585b501b5 --- /dev/null +++ b/18/eac176f245826c46c80044ca4861244963f9da @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 31BD9431FB6 + for ; Tue, 25 Dec 2012 06:34:34 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TQ6vQukzflAL for ; + Tue, 25 Dec 2012 06:34:30 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DC2DE431FAE + for ; Tue, 25 Dec 2012 06:34:30 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TnVaL-0001W4-DV; Tue, 25 Dec 2012 10:34:30 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TnVaF-0007KI-Rm; Tue, 25 Dec 2012 10:34:19 -0400 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/5] util: Function to parse boolean term queries +In-Reply-To: <87obhidxkt.fsf@zancas.localnet> +References: <1356415076-5692-1-git-send-email-amdragon@mit.edu> + <1356415076-5692-3-git-send-email-amdragon@mit.edu> + <87obhidxkt.fsf@zancas.localnet> +User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 25 Dec 2012 10:34:19 -0400 +Message-ID: <87ip7qdwus.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 25 Dec 2012 14:34:34 -0000 + +David Bremner writes: +> +> So if there is no quote, we skip the part after the ':'? I guess I +> probably missed something because that doesn't sound like the intended +> behaviour. + +Indeed the following addition to the test shows it works fine in +context. So I guess I just don't follow this control flow very well. + +diff --git a/test/dump-restore b/test/dump-restore +index aecc393..f9ae5b3 100755 +--- a/test/dump-restore ++++ b/test/dump-restore +@@ -200,6 +200,8 @@ a + # the next non-comment line should report an an empty tag error for + # batch tagging, but not for restore + + +e -- id:20091117232137.GA7669@griffis1.net ++# valid id, but warning about missing message +++e id:missing_message_id + EOF + + cat < EXPECTED +@@ -211,6 +213,7 @@ Warning: no query string after -- [+c +d --] + Warning: hex decoding of tag %zz failed [+%zz -- id:whatever] + Warning: cannot parse query: id:" + Warning: not an id query: tag:abc ++Warning: cannot apply tags to missing message: missing_message_id + EOF + + test_expect_equal_file EXPECTED OUTPUT -- 2.26.2