From 734d1ef7a52c3e2aaadb0633080052449ae4ed89 Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Sun, 13 May 2012 23:55:38 +0200 Subject: [PATCH] Re: [PATCH 0/5] Fix notmuch_database_get_directory API --- 7c/852fd1d6fc657a7afd966964766b549af344b3 | 94 +++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 7c/852fd1d6fc657a7afd966964766b549af344b3 diff --git a/7c/852fd1d6fc657a7afd966964766b549af344b3 b/7c/852fd1d6fc657a7afd966964766b549af344b3 new file mode 100644 index 000000000..d84e68ad4 --- /dev/null +++ b/7c/852fd1d6fc657a7afd966964766b549af344b3 @@ -0,0 +1,94 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EBF62431FB6 + for ; Sun, 13 May 2012 14:55:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nKP-KO2Z-0ep for ; + Sun, 13 May 2012 14:55:42 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7AA7C431FAE + for ; Sun, 13 May 2012 14:55:42 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id F3C61587DD8 + for ; Sun, 13 May 2012 23:55:40 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 5BCE2DF2A3; Sun, 13 May 2012 23:55:40 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de + [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client + certificate requested) (Authenticated sender: teythoon) by + mail.jade-hamburg.de (Postfix) with ESMTPSA id 0D7CFDF2A0; Sun, 13 May 2012 + 23:55:39 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1STglO-0004K0-I1; Sun, 13 May 2012 23:55:38 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +From: Justus Winter <4winter@informatik.uni-hamburg.de> +User-Agent: alot/0.3+ +To: Tomi Ollila , Austin Clements , + notmuch@notmuchmail.org +References: <1336939029-13969-1-git-send-email-amdragon@mit.edu> + +In-Reply-To: +Message-ID: <20120513215538.15106.43740@thinkbox.jade-hamburg.de> +Subject: Re: [PATCH 0/5] Fix notmuch_database_get_directory API +Date: Sun, 13 May 2012 23:55:38 +0200 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 13 May 2012 21:55:43 -0000 + +Quoting Tomi Ollila (2012-05-13 22:49:58) +> On Sun, May 13 2012, Austin Clements wrote: +> = + +> > This is a proposed last-minute change for 0.13. It fixes the +> > notmuch_database_get_directory API in the same way we're fixing +> > notmuch_database_open, etc in this release. Since this is a +> > backwards-incompatible change, it would be nice to lump it with the +> > other API-breaking changes. +> > +> > To keep the patch simple, this does not change the behavior of +> > notmuch_database_get_directory, but it puts us in a good position to +> > fix it in the future. +> = + +> Looks good to me (and applied in my current environment). The c/c++ = + +> changes were easy to understand and the python/go/ruby binding +> changes looks like the old changes -- but those who understand more +> (and actually uses those bindings) could do better review. + +I'd say the changes to the python and go bindings are fine. + +> It would be nice to get those in so that we may have chance not +> updating SONAME for notmuch 0.14. + +Yes, I'd love to see this in 0.13 as well, but I don't really see the +problem with breaking the api if this fixes design issues. After all, +notmuch is young and so are all the projects building uppon it. + +Justus -- 2.26.2