From 6defad2cdd8c58c754091ea698c13072ac6b0970 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 26 Dec 2012 10:47:16 +2000 Subject: [PATCH] Re: [PATCH 5/5] man: Update notmuch-dump(1) for new batch-tag format --- 22/16f662a649114213941bef9cc8f586dcf2502f | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 22/16f662a649114213941bef9cc8f586dcf2502f diff --git a/22/16f662a649114213941bef9cc8f586dcf2502f b/22/16f662a649114213941bef9cc8f586dcf2502f new file mode 100644 index 000000000..72f1b30cb --- /dev/null +++ b/22/16f662a649114213941bef9cc8f586dcf2502f @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 03071431FB6 + for ; Tue, 25 Dec 2012 06:47:29 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id iKBRtTVR6oeu for ; + Tue, 25 Dec 2012 06:47:28 -0800 (PST) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9A63B431FAE + for ; Tue, 25 Dec 2012 06:47:28 -0800 (PST) +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1TnVms-0001WX-GI; Tue, 25 Dec 2012 10:47:24 -0400 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1TnVmm-0007Qj-SZ; Tue, 25 Dec 2012 10:47:16 -0400 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 5/5] man: Update notmuch-dump(1) for new batch-tag format +In-Reply-To: <1356415076-5692-6-git-send-email-amdragon@mit.edu> +References: <1356415076-5692-1-git-send-email-amdragon@mit.edu> + <1356415076-5692-6-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.14+213~g4af1ac6 (http://notmuchmail.org) Emacs/24.2.1 + (x86_64-pc-linux-gnu) +Date: Tue, 25 Dec 2012 10:47:16 -0400 +Message-ID: <87fw2udw97.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 25 Dec 2012 14:47:29 -0000 + + +Overall I agree this is conceptually cleaner. Transforming between +quoting formats is inherently delicate; I suspect there will always be +at least one special case missed. I did find the dequoting code a bit +baffling, but this is more of an implementation issue. + +There is a certain cognitive dissonance in using hex-quoting for tags +and xapian-quoting for message-ids. Did you think about the +implications of using xapian quoting for tags as well? + +d -- 2.26.2