From 6b40dbe141cdfa73de314cee3df9268b2d4145f0 Mon Sep 17 00:00:00 2001 From: Adam Wolfe Gordon Date: Thu, 29 Mar 2012 21:15:10 +1800 Subject: [PATCH] emacs: Function `remove-if' from cl package called at runtime --- 36/287cd6bfefa6d20daf93d154f13e132e47bcaf | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 36/287cd6bfefa6d20daf93d154f13e132e47bcaf diff --git a/36/287cd6bfefa6d20daf93d154f13e132e47bcaf b/36/287cd6bfefa6d20daf93d154f13e132e47bcaf new file mode 100644 index 000000000..5c481ab37 --- /dev/null +++ b/36/287cd6bfefa6d20daf93d154f13e132e47bcaf @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 81B3B431FAF + for ; Wed, 28 Mar 2012 20:15:16 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TIXVmup1Apd1 for ; + Wed, 28 Mar 2012 20:15:14 -0700 (PDT) +Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com + [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 459D2431FAE + for ; Wed, 28 Mar 2012 20:15:14 -0700 (PDT) +Received: by lahc1 with SMTP id c1so2035200lah.26 + for ; Wed, 28 Mar 2012 20:15:11 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=mime-version:sender:x-originating-ip:date:x-google-sender-auth + :message-id:subject:from:to:content-type:x-gm-message-state; + bh=qvuPXUx5DZB7yU0UIXtkkPhbx72J39t81znuRo1fx9s=; + b=ANUs5yZvsB7yV6yO+uuLlc/0VabR2FOMSgB4731hRGZbzOf0H6oE+eD+p1p9Puc1lI + 0PGK7RhNL3ge7eXT9/+mEiqz3mvz7JbD9pxomaOzL2O/IdPnJZf0fShRPujc1MVNnZlr + wgkrsE6iU0Gx6UocZFlWCl45JaPZEj0MqUATuRLayfnYVA+kycszHlHa9NLOjhpxuRsn + n96jNrLb6mD/HIjsJQoHl+T80OpXLcFMzeGjuaLZyh4k3iy1gVUWi1BtjgQM50GrUmdp + 2eBiM83qWgfPhYmMu19Ln36UCD5DBJ+PyH6By7WC6WqQWaYgYG076XVV0tQ4zDygqGQP + Yh2Q== +MIME-Version: 1.0 +Received: by 10.152.129.74 with SMTP id nu10mr21127591lab.50.1332990911133; + Wed, 28 Mar 2012 20:15:11 -0700 (PDT) +Sender: awg@xvx.ca +Received: by 10.112.29.137 with HTTP; Wed, 28 Mar 2012 20:15:10 -0700 (PDT) +X-Originating-IP: [96.52.216.56] +Date: Wed, 28 Mar 2012 21:15:10 -0600 +X-Google-Sender-Auth: y3_JFGGaZKohdZ0-x6slw9JSOd0 +Message-ID: + +Subject: emacs: Function `remove-if' from cl package called at runtime +From: Adam Wolfe Gordon +To: Notmuch Mail +Content-Type: text/plain; charset=ISO-8859-1 +X-Gm-Message-State: + ALoCoQllt1cJvse4LVrFTrkMVigcbW89B9QFLbn9TZMPd1IP46xfAg4G6ZufaaP/mr0k2XTV9kpM +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 29 Mar 2012 03:15:16 -0000 + +Hi everyone, + +As I was fixing the Refrences bug tonight (patch forthcoming), I +introduced another usage of a cl library function that produces the +warning from emacs: +Warning: Function `remove-if' from cl package called at runtime + +Reading a bit about this warning, it sounds like the reason for it is +that remove-if et al. are functions, so they can be replaced by some +other package, and the emacs folks don't want packages included with +emacs to use them because they would then break if the functions were +redefined. Are we worried about this in notmuch? It seems to me like +it's mostly political, but I'm pretty new to the emacs lisp world. + +I remember that some time ago it was decided that we were OK with +using functions the cl library where it improves code quality. What do +we think of using functions that cause the "called at runtime" +warning? + +-- +Adam Wolfe Gordon -- 2.26.2