From 6aa0da03a6383e6cc1faddbdd6c3bc049327195b Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Tue, 25 Dec 2012 11:04:39 +0000 Subject: [PATCH] Re: [PATCH] emacs: show: make id links respect window --- ac/9e2128ac8f119e3995a085876602bd286a584f | 109 ++++++++++++++++++++++ 1 file changed, 109 insertions(+) create mode 100644 ac/9e2128ac8f119e3995a085876602bd286a584f diff --git a/ac/9e2128ac8f119e3995a085876602bd286a584f b/ac/9e2128ac8f119e3995a085876602bd286a584f new file mode 100644 index 000000000..190d33e67 --- /dev/null +++ b/ac/9e2128ac8f119e3995a085876602bd286a584f @@ -0,0 +1,109 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id EF22A431FBC + for ; Tue, 25 Dec 2012 03:04:52 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yyrAkiKXi+qJ for ; + Tue, 25 Dec 2012 03:04:49 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C1B22431FAE + for ; Tue, 25 Dec 2012 03:04:48 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1TnSJJ-0005z3-AI; Tue, 25 Dec 2012 11:04:41 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1TnSJI-0005Cq-Vr; Tue, 25 Dec 2012 11:04:37 +0000 +From: Mark Walters +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: make id links respect window +In-Reply-To: <87bodjfnt0.fsf@zancas.localnet> +References: <1355958602-16752-1-git-send-email-markwalters1009@gmail.com> + <87bodjfnt0.fsf@zancas.localnet> +User-Agent: Notmuch/0.14+236~g1d0044f (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Tue, 25 Dec 2012 11:04:39 +0000 +Message-ID: <87mwx2jsu0.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 743ce505548e1d48a5755a25b381a98e (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 25 Dec 2012 11:04:53 -0000 + + +On Mon, 24 Dec 2012, David Bremner wrote: +> Mark Walters writes: +> +>> I think this is a bug but that could be debated. It is particularly +>> easy to trigger with notmuch pick because that uses the split pane +>> while focus usually remains in the `pick' pane rather than the `show' +>> pane. +> +> I can imagine that people would want/like the "open in other window" +> effect of the current code, even if the reason is a bug. + +That's definitely possible. I generally expect a mouse click to select +the window I click and this feels counter intuitive. I think that some +people might like an option "open this link in a new window" but I would +guess that would like that whether they clicked or pressed RET on the +button. + +>> 'action `(lambda (arg) +>> (notmuch-show ,(third link))) + +> Can you (or someone) explain why backquote is needed here? Is this some +> kind of workaround for lack of lexical scope? If so, maybe a comment. + +I think this is a reasonably standard use: we want "(third link)" to be +evaluated when the button is made, but we want the rest of the action to +be evaluated when the action is called. + +Best wishes + +Mark + +> +> d -- 2.26.2