From 6a4dc191e04dff7f7f322c0bb2a8bcfc79727de1 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Wed, 24 Oct 2012 09:43:52 +0200 Subject: [PATCH] Re: [ANN] notmuch-labeler: Improves notmuch way of displaying labels --- a9/84271e41677ee647497c25471ee1b8c1ba2288 | 101 ++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 a9/84271e41677ee647497c25471ee1b8c1ba2288 diff --git a/a9/84271e41677ee647497c25471ee1b8c1ba2288 b/a9/84271e41677ee647497c25471ee1b8c1ba2288 new file mode 100644 index 000000000..c7ba6e7b1 --- /dev/null +++ b/a9/84271e41677ee647497c25471ee1b8c1ba2288 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id CE590431FAF + for ; Wed, 24 Oct 2012 00:44:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id v9B32+-mI3Uu for ; + Wed, 24 Oct 2012 00:44:16 -0700 (PDT) +Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com + [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id C1862431FAE + for ; Wed, 24 Oct 2012 00:44:15 -0700 (PDT) +Received: by mail-bk0-f53.google.com with SMTP id jg15so78275bkc.26 + for ; Wed, 24 Oct 2012 00:44:13 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:from:date:message-id:subject:to + :cc:content-type; + bh=ermHWsgdZrU73EHyTbkesHtF1w3PvS1xIs7nPd+77Yw=; + b=BLGf+3UpN1Og52eCjBWeQkto9yJG5kkf23L7aMC5ylweaxVD83rdRR6HOKrfQV2TiS + lKjtvqAPEX8O8aOyMEWQTLt6kpVVBtvulqdgrgZhfe7IImFzW9HfjH2qhxHLmO2DylTo + vgUdU9OBbQ/0T89p68Wki/fNE+415mVMY3h4rkAgVAVs0s2pBYv7qXHW/58rHghw4hV7 + WhNU4wKX/YPsYcTJoZuJ2vVu3iyWgPnNg9A8LNoJypundxsRSwshwVW7fElyWNI2Zvc2 + fDY3SzpsfjJyztPLyAgaG4/2EOE+5h6osfwbzq64t87euMYA0bfXZtGpGohQaBWVg4ZZ + i9gg== +Received: by 10.204.150.200 with SMTP id z8mr4323111bkv.139.1351064653006; + Wed, 24 Oct 2012 00:44:13 -0700 (PDT) +MIME-Version: 1.0 +Received: by 10.204.57.5 with HTTP; Wed, 24 Oct 2012 00:43:52 -0700 (PDT) +In-Reply-To: <87lifbmxfg.fsf@maritornes.cs.unb.ca> +References: + + <87lifbmxfg.fsf@maritornes.cs.unb.ca> +From: Damien Cassou +Date: Wed, 24 Oct 2012 09:43:52 +0200 +Message-ID: + +Subject: Re: [ANN] notmuch-labeler: Improves notmuch way of displaying labels +To: David Bremner +Content-Type: text/plain; charset=ISO-8859-1 +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 24 Oct 2012 07:44:17 -0000 + +Hi, + +On Fri, Oct 12, 2012 at 7:07 PM, David Bremner wrote: +> It seeems like a nice UI enchancement, and people would not have to use +> it if they didn't like it, so in principle I guess we should work +> towards integrating it into notmuch upstream. + + +does anyone else agrees? Should I spend time on that or does nobody care? + + +> I'm not an elisp expert, but I did find it strange to use use defadvice +> on your own code. Maybe I'm just too conservative. + + +I let myself advise my own code only when no duplication is involved +and when the dependencies between the modules that contain the +function and its pieces of advice are well defined. I have no problem +using a different mechanism (such a function variable and calling +funcall) if integration into notmuch is desired but not defadvice. + + +> At some point we should probably get a patch series against notmuch +> mainline; I'll let other people comment on whether yes, now is the time +> (and thereby volunteering to review the patches ;). + +Anyone interested in notmuch-labeler? +https://github.com/DamienCassou/notmuch-labeler (there are screenshots +there) + +-- +Damien Cassou +http://damiencassou.seasidehosting.st + +"Success is the ability to go from one failure to another without +losing enthusiasm." +Winston Churchill -- 2.26.2