From 68ca01e38b723a720a3a394d0791a6f191a225f8 Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Mon, 24 Sep 2012 12:31:52 +0200 Subject: [PATCH] RFC: Annotate internal_error with the attribute noreturn 2nd patchset --- 35/21eef02c49957c31c215da3b0d9a88ac122afd | 70 +++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 35/21eef02c49957c31c215da3b0d9a88ac122afd diff --git a/35/21eef02c49957c31c215da3b0d9a88ac122afd b/35/21eef02c49957c31c215da3b0d9a88ac122afd new file mode 100644 index 000000000..7a8b3663f --- /dev/null +++ b/35/21eef02c49957c31c215da3b0d9a88ac122afd @@ -0,0 +1,70 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 750B3431FAF + for ; Mon, 24 Sep 2012 03:32:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.001 +X-Spam-Level: +X-Spam-Status: No, score=0.001 tagged_above=-999 required=5 + tests=[UNPARSEABLE_RELAY=0.001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 4meeVjsuDVYD for ; + Mon, 24 Sep 2012 03:32:16 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id A9F0D431FAE + for ; Mon, 24 Sep 2012 03:32:16 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id 085AB5AA8E7 + for ; Mon, 24 Sep 2012 12:32:14 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 31837DF2A8; Mon, 24 Sep 2012 12:32:13 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (unknown + [IPv6:fe80::216:d3ff:fe3e:5058%br0]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) (Authenticated sender: teythoon) + by mail.jade-hamburg.de (Postfix) with ESMTPSA id 22A94DF2A1 + for ; Mon, 24 Sep 2012 12:32:12 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.80) + (envelope-from ) + id 1TG5xR-0002hy-Nb + for notmuch@notmuchmail.org; Mon, 24 Sep 2012 12:32:09 +0200 +From: Justus Winter <4winter@informatik.uni-hamburg.de> +To: notmuch@notmuchmail.org +Subject: RFC: Annotate internal_error with the attribute noreturn 2nd patchset +Date: Mon, 24 Sep 2012 12:31:52 +0200 +Message-Id: + <1348482717-10340-1-git-send-email-4winter@informatik.uni-hamburg.de> +X-Mailer: git-send-email 1.7.10.4 +In-Reply-To: <20120922161256.GE26662@mit.edu> +References: <20120922161256.GE26662@mit.edu> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 24 Sep 2012 10:32:17 -0000 + +Thanks for your feedback. I've updated the patch series accordingly. + +We need to discuss where those kind of macro definitions abstracting +away compiler differences should go. None of the files in util +includes notmuch-private.h, so I was unsure whether it's okay to put +them there. + +Justus + -- 2.26.2