From 65ab77b72844a9d607619072044a32dce51bf49d Mon Sep 17 00:00:00 2001 From: Pieter Praet Date: Fri, 24 Feb 2012 23:33:03 +0100 Subject: [PATCH] Re: [PATCH 1/6] test: emacs: new tests "notmuch-show: {add, remove} multiple tags {to, from} single message" --- 21/dd7eb5ce2873acb41f72c3697e96f13bb6aa59 | 165 ++++++++++++++++++++++ 1 file changed, 165 insertions(+) create mode 100644 21/dd7eb5ce2873acb41f72c3697e96f13bb6aa59 diff --git a/21/dd7eb5ce2873acb41f72c3697e96f13bb6aa59 b/21/dd7eb5ce2873acb41f72c3697e96f13bb6aa59 new file mode 100644 index 000000000..76ca31802 --- /dev/null +++ b/21/dd7eb5ce2873acb41f72c3697e96f13bb6aa59 @@ -0,0 +1,165 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 7EB4B40A2BC + for ; Fri, 24 Feb 2012 14:35:20 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id uNKwvZN9g6gh for ; + Fri, 24 Feb 2012 14:35:19 -0800 (PST) +Received: from mail-we0-f181.google.com (mail-we0-f181.google.com + [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 9F5ED409F00 + for ; Fri, 24 Feb 2012 14:35:19 -0800 (PST) +Received: by werp13 with SMTP id p13so2017659wer.26 + for ; Fri, 24 Feb 2012 14:35:18 -0800 (PST) +Received-SPF: pass (google.com: domain of pieter@praet.org designates + 10.181.11.227 as permitted sender) client-ip=10.181.11.227; +Authentication-Results: mr.google.com; + spf=pass (google.com: domain of pieter@praet.org + designates 10.181.11.227 as permitted sender) + smtp.mail=pieter@praet.org +Received: from mr.google.com ([10.181.11.227]) + by 10.181.11.227 with SMTP id el3mr8855363wid.18.1330122918473 + (num_hops = 1); Fri, 24 Feb 2012 14:35:18 -0800 (PST) +Received: by 10.181.11.227 with SMTP id el3mr7119811wid.18.1330122918390; + Fri, 24 Feb 2012 14:35:18 -0800 (PST) +Received: from localhost ([109.131.181.26]) + by mx.google.com with ESMTPS id m16sm14684643wie.9.2012.02.24.14.35.17 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 24 Feb 2012 14:35:17 -0800 (PST) +From: Pieter Praet +To: Dmitry Kurochkin , + David Bremner +Subject: Re: [PATCH 1/6] test: emacs: new tests "notmuch-show: {add, + remove} multiple tags {to, from} single message" +In-Reply-To: <87ipiwjz85.fsf@gmail.com> +References: <878vjtqhcg.fsf@praet.org> + <1330038554-10347-1-git-send-email-pieter@praet.org> + <87ipiwjz85.fsf@gmail.com> +User-Agent: Notmuch/0.11.1+210~g6afc43e (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +Date: Fri, 24 Feb 2012 23:33:03 +0100 +Message-ID: <87aa47euao.fsf@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQnq4jDapgrWi38sBuho1ryjumNwatItN+GsxTHv8e7ef73v+l4zSHT9FC8WEzWT3rxmjhzG +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 24 Feb 2012 22:35:20 -0000 + +On Fri, 24 Feb 2012 14:35:22 +0400, Dmitry Kurochkin wrote: +> On Fri, 24 Feb 2012 00:09:09 +0100, Pieter Praet wrote: +> > * test/emacs: +> > +> > - Rename subtests "{Add,Remove} tag from notmuch-show view" to +> > "notmuch-show: {add,remove} single tag {to,from} single message" +> > to be consistent with the following tests. +> > +> > - New subtest "notmuch-show: add multiple tags to single message": +> > `notmuch-show-add-tag' ("+") can add multiple tags to a message. +> > +> > - New subtest "notmuch-show: remove multiple tags from single message": +> > `notmuch-show-remove-tag' ("-") can remove multiple tags from a message. +> > --- +> +> Would be nice to have another patch that moves notmuch-show tests to +> emacs-show file. +> + +TL;DR: It's on my todo list. + +Yeah, the Emacs test series *as a whole* desperately needs some +reorganizing, not in the least because it's still severely +lacking in coverage. + +Some more structure/consistency would considerably increase the +feasibility (or at least reduce the PITAness...) of filling in +the numerous blanks and reducing duplication of effort (regarding +both hard- and wetware based cycles), as well as increasing the +likelihood that developers (not looking in any specific direction) +serve their code with a side dish of tests. + +Ideally (IMHO), it would be split up into separate files by mode, +i.e. `notmuch-hello', `notmuch-search', `notmuch-show', +`notmuch-{message,mua}', and those can be further divided into +sections like navigation, tagging, visibility stuff, hooks, ... + +There's probably quite a number of implicit interdependencies that +need to be taken care of though, and I (as well as others) still +have a bunch of tests waiting to be applied, so we might want to do +this gradually. + + +> Regards, +> Dmitry +> +> > test/emacs | 16 ++++++++++++++-- +> > 1 files changed, 14 insertions(+), 2 deletions(-) +> > +> > diff --git a/test/emacs b/test/emacs +> > index b74cfa9..ec1dbb0 100755 +> > --- a/test/emacs +> > +++ b/test/emacs +> > @@ -112,18 +112,30 @@ test_emacs "(notmuch-search \"$os_x_darwin_thread\") +> > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize) +> > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)" +> > +> > -test_begin_subtest "Add tag from notmuch-show view" +> > +test_begin_subtest "notmuch-show: add single tag to single message" +> > test_emacs "(notmuch-show \"$os_x_darwin_thread\") +> > (execute-kbd-macro \"+tag-from-show-view\")" +> > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize) +> > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag-from-show-view unread)" +> > +> > -test_begin_subtest "Remove tag from notmuch-show view" +> > +test_begin_subtest "notmuch-show: remove single tag from single message" +> > test_emacs "(notmuch-show \"$os_x_darwin_thread\") +> > (execute-kbd-macro \"-tag-from-show-view\")" +> > output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize) +> > test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)" +> > +> > +test_begin_subtest "notmuch-show: add multiple tags to single message" +> > +test_emacs "(notmuch-show \"$os_x_darwin_thread\") +> > + (execute-kbd-macro \"+tag1-from-show-view +tag2-from-show-view\")" +> > +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize) +> > +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox tag1-from-show-view tag2-from-show-view unread)" +> > + +> > +test_begin_subtest "notmuch-show: remove multiple tags from single message" +> > +test_emacs "(notmuch-show \"$os_x_darwin_thread\") +> > + (execute-kbd-macro \"-tag1-from-show-view -tag2-from-show-view\")" +> > +output=$(notmuch search $os_x_darwin_thread | notmuch_search_sanitize) +> > +test_expect_equal "$output" "thread:XXX 2009-11-18 [4/4] Jjgod Jiang, Alexander Botero-Lowry; [notmuch] Mac OS X/Darwin compatibility issues (inbox unread)" +> > + +> > test_begin_subtest "Message with .. in Message-Id:" +> > add_message [id]=123..456@example '[subject]="Message with .. in Message-Id"' +> > test_emacs '(notmuch-search "id:\"123..456@example\"") +> > -- +> > 1.7.8.1 +> > + + +Peace + +-- +Pieter -- 2.26.2