From 64d475cac5a2e4ca9a63a3f158c6f6ee745cb9a0 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20G=C3=B3rny?= Date: Thu, 8 Mar 2018 16:48:39 +0100 Subject: [PATCH] linux-info.eclass: get_localversion, do not call 'ls' Use bash array to perform a safe filename glob instead of calling 'ls'. Also, use nullglob to cleanly handle no matches instead of silencing errors. --- eclass/linux-info.eclass | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass index dd62b26855d2..0eca55725874 100644 --- a/eclass/linux-info.eclass +++ b/eclass/linux-info.eclass @@ -390,8 +390,13 @@ kernel_is() { get_localversion() { local lv_list i x + local shopt_save=$(shopt -p nullglob) + shopt -s nullglob + local files=( ${1}/localversion* ) + ${shopt_save} + # ignore files with ~ in it. - for i in $(ls ${1}/localversion* 2>/dev/null); do + for i in "${files[@]}"; do [[ -n ${i//*~*} ]] && lv_list="${lv_list} ${i}" done -- 2.26.2