From 64a2b3d4ef32b9405f85895e04e1fac8a29ce739 Mon Sep 17 00:00:00 2001 From: Justus Winter <4winter@informatik.uni-hamburg.de> Date: Sun, 13 May 2012 23:51:35 +0200 Subject: [PATCH] Re: [PATCH 2/5] go: Update for changes to notmuch_database_get_directory --- cd/d93f362970e833085bb4573b97127553e109ad | 84 +++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 cd/d93f362970e833085bb4573b97127553e109ad diff --git a/cd/d93f362970e833085bb4573b97127553e109ad b/cd/d93f362970e833085bb4573b97127553e109ad new file mode 100644 index 000000000..b2857aacf --- /dev/null +++ b/cd/d93f362970e833085bb4573b97127553e109ad @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D7B46431FB6 + for ; Sun, 13 May 2012 14:52:55 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Xrgk+Y+YazXb for ; + Sun, 13 May 2012 14:52:54 -0700 (PDT) +Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id DEAB3431FAE + for ; Sun, 13 May 2012 14:52:53 -0700 (PDT) +Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228]) + (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) + (No client certificate requested) + by mail.cryptobitch.de (Postfix) with ESMTPSA id DA725587D9F + for ; Sun, 13 May 2012 23:52:51 +0200 (CEST) +Received: by mail.jade-hamburg.de (Postfix, from userid 401) + id 5AFBEDF2A3; Sun, 13 May 2012 23:52:51 +0200 (CEST) +Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de + [10.1.1.153]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client + certificate requested) (Authenticated sender: teythoon) by + mail.jade-hamburg.de (Postfix) with ESMTPSA id 608E9DF2A0; Sun, 13 May 2012 + 23:52:39 +0200 (CEST) +Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77) + (envelope-from ) + id 1STghT-0004Ff-7V; Sun, 13 May 2012 23:51:35 +0200 +Content-Type: text/plain; charset="utf-8" +MIME-Version: 1.0 +Content-Transfer-Encoding: quoted-printable +To: Austin Clements , notmuch@notmuchmail.org +From: Justus Winter <4winter@informatik.uni-hamburg.de> +In-Reply-To: <1336939029-13969-3-git-send-email-amdragon@mit.edu> +References: <1336939029-13969-1-git-send-email-amdragon@mit.edu> + <1336939029-13969-3-git-send-email-amdragon@mit.edu> +Message-ID: <20120513215135.15106.40581@thinkbox.jade-hamburg.de> +User-Agent: alot/0.3+ +Subject: Re: [PATCH 2/5] go: Update for changes to + notmuch_database_get_directory +Date: Sun, 13 May 2012 23:51:35 +0200 +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 13 May 2012 21:52:56 -0000 + +Hi Austin, + +thanks for taking care of this. + +Quoting Austin Clements (2012-05-13 21:57:06) +> --- +> bindings/go/src/notmuch/notmuch.go | 13 +++++++------ +> bindings/python/notmuch/database.py | 4 ++-- + +A change to the python bindings slipped into this one. + +Other than that this looks good. + +I just saw that I marked another function as problematic, +notmuch_database_find_message_by_filename ends up calling +_notmuch_directory_create that aborts if the database is not +writable. But this might have to wait and might not even requira an +api change. + +Justus -- 2.26.2