From 6365469933e4d362a96d599ceacd7122b2a76e29 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 25 May 2012 17:57:06 +2000 Subject: [PATCH] Re: [PATCH v3 3/4] new: Merge error checks from add_files and add_files_recursive --- d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b diff --git a/d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b b/d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b new file mode 100644 index 000000000..bf8002518 --- /dev/null +++ b/d2/b0d02b9fcf5c8376a95e6e5b4e448c104a394b @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0D6A2431FC3 + for ; Thu, 24 May 2012 14:57:13 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 1Ab7u5tXQk90 for ; + Thu, 24 May 2012 14:57:09 -0700 (PDT) +Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU + [18.7.68.35]) + by olra.theworths.org (Postfix) with ESMTP id EFB7A431FBD + for ; Thu, 24 May 2012 14:57:08 -0700 (PDT) +X-AuditID: 12074423-b7fcc6d0000008a8-05-4fbeaeb44e96 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id 8A.77.02216.4BEAEBF4; Thu, 24 May 2012 17:57:08 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q4OLv8i9016228; + Thu, 24 May 2012 17:57:08 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q4OLv7hT008328 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Thu, 24 May 2012 17:57:08 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SXg1r-0006DG-19; Thu, 24 May 2012 17:57:07 -0400 +Date: Thu, 24 May 2012 17:57:06 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v3 3/4] new: Merge error checks from add_files and + add_files_recursive +Message-ID: <20120524215706.GA11804@mit.edu> +References: <1336429240-1114-1-git-send-email-amdragon@mit.edu> + <1337887922-13163-1-git-send-email-amdragon@mit.edu> + <1337887922-13163-4-git-send-email-amdragon@mit.edu> + <87wr415mc3.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87wr415mc3.fsf@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hRV1t2ybp+/wc+7yhZN050trt+cyezA + 5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZdw7cYS5YClrxdlDs1kbGPtYuhg5OSQETCQm + 3N8LZYtJXLi3nq2LkYtDSGAfo8SdJy2sEM4GRokDuztZIJyTTBKtc54xQThLGCWOHOwHynBw + sAioSsxo8gYZxSagIbFt/3JGEFtEQFFi88n9YDazgLTEt9/NTCC2sECMxJJHZ9hAbF4BHYme + 62+hZp5mlLjV3coOkRCUODnzCQtEs5bEjX8vmUB2gQxa/o8DJMwJtGvt9G1gM0UFVCSmnNzG + NoFRaBaS7llIumchdC9gZF7FKJuSW6Wbm5iZU5yarFucnJiXl1qka6aXm1mil5pSuokRFNbs + Lso7GP8cVDrEKMDBqMTDyxi9z1+INbGsuDL3EKMkB5OSKO+P1UAhvqT8lMqMxOKM+KLSnNTi + Q4wSHMxKIryCkUA53pTEyqrUonyYlDQHi5I471rN3f5CAumJJanZqakFqUUwWRkODiUJXn5g + /AoJFqWmp1akZeaUIKSZODhBhvMADWcCqeEtLkjMLc5Mh8ifYlSUEuf9uBYoIQCSyCjNg+uF + pZ1XjOJArwjzsoO08wBTFlz3K6DBTECDtzzeCzK4JBEhJdXA6LSt+h3HjcLVIcZq6S6urie/ + +MwKm3OBKy/ksqzfwbTm9M7WJsZTrFYWqytkRV62L/CQ+y77/ULQ74ldPstcBSYYTNy3Qvbg + Sbu0y6vvWZUF6xZs0P8/R+J/9bOEPeGTt76be3f3tod/Z9sdkQ4LYb0SeG62/ofPLDrz+j/2 + 7bu5oedn+yP9BiWW4oxEQy3mouJEAB0G0H8WAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 24 May 2012 21:57:13 -0000 + +Quoth Jani Nikula on May 24 at 11:57 pm: +> On Thu, 24 May 2012, Austin Clements wrote: +> > Before XXX, add_files_recursive could have been called on a symlink to +> > a non-directory. Hence, calling it on a non-directory was not an +> > error, so a separate function, add_files, existed to fail loudly in +> > situations where the path had to be a directory. +> +> "Before XXX"? + +Arg. I meant to replace that with a commit ID, but now I don't +remember what commit I wanted to reference. + +> Otherwise, this 3/4 and following 4/4 patch LGTM. I didn't bother +> looking at 1/4 and 2/4 again, as you say there were no changes. +> +> +> BR, +> Jani. -- 2.26.2