From 6293e21d01b94628fe882caade9cea7d8e5b8783 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 2 Sep 2012 23:34:44 +2100 Subject: [PATCH] Re: [PATCH 1/3] lib: fix NULL checks for filenames iterators --- 4e/178876547c032182f481788d115a184c1c9f95 | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 4e/178876547c032182f481788d115a184c1c9f95 diff --git a/4e/178876547c032182f481788d115a184c1c9f95 b/4e/178876547c032182f481788d115a184c1c9f95 new file mode 100644 index 000000000..450bb0ee4 --- /dev/null +++ b/4e/178876547c032182f481788d115a184c1c9f95 @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2C256431FB6 + for ; Sat, 1 Sep 2012 19:34:54 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Ijrebvm0tUft for ; + Sat, 1 Sep 2012 19:34:53 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + (using TLSv1 with cipher AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 99CFB431FAF + for ; Sat, 1 Sep 2012 19:34:53 -0700 (PDT) +Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.89.108] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) + (envelope-from ) + id 1T801R-0007Wp-MZ; Sat, 01 Sep 2012 23:34:52 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1T801M-0003iM-9o; Sat, 01 Sep 2012 23:34:44 -0300 +From: David Bremner +To: Sascha Silbe , + notmuch +Subject: Re: [PATCH 1/3] lib: fix NULL checks for filenames iterators +In-Reply-To: <1340555366-25891-2-git-send-email-sascha-pgp@silbe.org> +References: <1340555366-25891-1-git-send-email-sascha-pgp@silbe.org> + <1340555366-25891-2-git-send-email-sascha-pgp@silbe.org> +User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Sep 2012 23:34:44 -0300 +Message-ID: <871uilcfuj.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Sep 2012 02:34:54 -0000 + +Sascha Silbe writes: + +> The API documentation (notmuch.h) states that the parameter may be NULL, +> but the implementation only checked the current element, potentially +> dereferencing a NULL pointer in the process. +> + +Pushed this one patch. + +d -- 2.26.2