From 618c25f5aad881d0126bd9df6be5630d4a7c04b0 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 30 Jan 2012 16:38:55 +0200 Subject: [PATCH] Re: [PATCH] STYLE: Initial draft of coding style document --- c4/35f3480da99dbb814635f491950e3cc28771b2 | 89 +++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 c4/35f3480da99dbb814635f491950e3cc28771b2 diff --git a/c4/35f3480da99dbb814635f491950e3cc28771b2 b/c4/35f3480da99dbb814635f491950e3cc28771b2 new file mode 100644 index 000000000..5e87ece15 --- /dev/null +++ b/c4/35f3480da99dbb814635f491950e3cc28771b2 @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5E5FE431E64 + for ; Mon, 30 Jan 2012 06:38:53 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RMU7P9D2eA9S for ; + Mon, 30 Jan 2012 06:38:52 -0800 (PST) +Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66]) + by olra.theworths.org (Postfix) with ESMTP id B88CA431FBC + for ; Mon, 30 Jan 2012 06:38:52 -0800 (PST) +Received: by guru.guru-group.fi (Postfix, from userid 501) + id A330068056; Mon, 30 Jan 2012 16:38:55 +0200 (EET) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] STYLE: Initial draft of coding style document +In-Reply-To: <1327708018-1107-1-git-send-email-david@tethera.net> +References: <1327708018-1107-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.11+129~g3b527ae (http://notmuchmail.org) Emacs/23.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: David Bremner +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 30 Jan 2012 14:38:53 -0000 + +On Fri, 27 Jan 2012 19:46:58 -0400, David Bremner wrote: +> From: David Bremner + +[ ... ] + +> + +> +* Indent is 4 spaces with mixed tabs/spaces and a tab width of 8. +> + Tabs should be only at the beginning of the line. + +So, after initial indentation (with tabs) there should not be further +tabs? We'll be using the former instead of the latter in these 2 below? + +/* excerpt from command-line-arguments.h -- indentation without tabs */ + +enum notmuch_opt_type { + NOTMUCH_OPT_END = 0, + NOTMUCH_OPT_BOOLEAN, /* --verbose */ + NOTMUCH_OPT_INT, /* --frob=8 */ + NOTMUCH_OPT_KEYWORD, /* --format=raw|json|text */ + NOTMUCH_OPT_STRING, /* --file=/tmp/gnarf.txt */ + NOTMUCH_OPT_POSITION /* notmuch dump pos_arg */ +}; + +/* excerpt from command-line-arguments.h -- indentation with tabs */ + +enum notmuch_opt_type { + NOTMUCH_OPT_END = 0, + NOTMUCH_OPT_BOOLEAN, /* --verbose */ + NOTMUCH_OPT_INT, /* --frob=8 */ + NOTMUCH_OPT_KEYWORD, /* --format=raw|json|text */ + NOTMUCH_OPT_STRING, /* --file=/tmp/gnarf.txt */ + NOTMUCH_OPT_POSITION /* notmuch dump pos_arg */ +}; + + +[ ... ] + + +Tomi -- 2.26.2