From 60c9c74ebbdcca56d1c74b8c14302c7d358613f9 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Wed, 8 Aug 2012 14:26:37 +2000 Subject: [PATCH] Re: [PATCH v2] emacs: notmuch search bugfix --- a9/4b53822182a084dbdba6fcfedc38737bf39534 | 97 +++++++++++++++++++++++ 1 file changed, 97 insertions(+) create mode 100644 a9/4b53822182a084dbdba6fcfedc38737bf39534 diff --git a/a9/4b53822182a084dbdba6fcfedc38737bf39534 b/a9/4b53822182a084dbdba6fcfedc38737bf39534 new file mode 100644 index 000000000..1238a041c --- /dev/null +++ b/a9/4b53822182a084dbdba6fcfedc38737bf39534 @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1479A431FC0 + for ; Tue, 7 Aug 2012 11:26:41 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Tn3c-49hEVwT for ; + Tue, 7 Aug 2012 11:26:40 -0700 (PDT) +Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU + [18.7.68.36]) + by olra.theworths.org (Postfix) with ESMTP id 91FC0431FAF + for ; Tue, 7 Aug 2012 11:26:40 -0700 (PDT) +X-AuditID: 12074424-b7fa06d0000008c2-ec-50215ddfb3a1 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP + id 85.31.02242.FDD51205; Tue, 7 Aug 2012 14:26:39 -0400 (EDT) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q77IQcjX031950; + Tue, 7 Aug 2012 14:26:39 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q77IQbjC000088 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Tue, 7 Aug 2012 14:26:38 -0400 (EDT) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1SyoUH-0003IK-9i; Tue, 07 Aug 2012 14:26:37 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH v2] emacs: notmuch search bugfix +In-Reply-To: <877gta1x4d.fsf@qmul.ac.uk> +References: <87boinpqfg.fsf@qmul.ac.uk> <20120806234732.GM22601@mit.edu> + <87pq72bthc.fsf@qmul.ac.uk> <20120807160352.GA2811@mit.edu> + <877gta1x4d.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.13.2+131~g3e2f67b (http://notmuchmail.org) Emacs/23.3.1 + (i486-pc-linux-gnu) +Date: Tue, 07 Aug 2012 14:26:37 -0400 +Message-ID: <87lihqtv6q.fsf@awakening.csail.mit.edu> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFnrDIsWRmVeSWpSXmKPExsUixCmqrXs/VjHAYMoNUYvVc3ksrt+cyezA + 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZRxYdIu94BtbxeVTUxkbGK+xdjFycEgImEg8 + blPrYuQEMsUkLtxbz9bFyMUhJLCPUWLZojmMEM56RokPD++yQDgnmCTWLr3PDOEsYZQ4dXAR + G0g/m4CGxLb9yxlBbBEBHYnbhxawg9jMAtIS3343M4GsEwZat2qjHkiYE6h8z8y/UOsWAG34 + dg5sjqhAosT9VX9YQWwWAVWJX9OXgcV5gXoPf1/MCGELSpyc+YQFYr6WxI1/L5kmMArOQpKa + hSS1gJFpFaNsSm6Vbm5iZk5xarJucXJiXl5qka65Xm5miV5qSukmRlCgsruo7GBsPqR0iFGA + g1GJh/cCl0KAEGtiWXFl7iFGSQ4mJVHeAFfFACG+pPyUyozE4oz4otKc1OJDjBIczEoivId3 + ApXzpiRWVqUW5cOkpDlYlMR5r6fc9BcSSE8sSc1OTS1ILYLJynBwKEnwnvIEGipYlJqeWpGW + mVOCkGbi4AQZzgM0/AxIDW9xQWJucWY6RP4Uo6KUOO9JkIQASCKjNA+uF5ZIXjGKA70izPsA + pIoHmITgul8BDWYCGuwtLwcyuCQRISXVwFgbJVqRvjiKu3+v1M+tzffzpmj4T90uLR6m9//1 + A5nHn39MWhG3iSlYZK+TkKyFoOqTZRH1sxs3cCwpibtvafrxjOA8pbP/tiqs/pO/J6+N44b/ + f92DqQLH6/6H7hLT9jr1pf7uHllRI8HcGQnHnzaIGp56r+2qerHHfJFam+fenGWioiHpU5RY + ijMSDbWYi4oTAZEeNFr/AgAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 07 Aug 2012 18:26:41 -0000 + +On Tue, 07 Aug 2012, Mark Walters wrote: +> The recent change to use json for notmuch-search.el introduced a bug +> in the code for keeping position on refresh. The problem is a +> comparison between (plist-get result :thread) and a thread-id returned +> by notmuch-search-find-thread-id: the latter is prefixed with +> "thread:" +> +> We fix this by adding an option to notmuch-search-find-thread-id to +> return the bare thread-id. It appears that notmuch-search-refresh-view +> is the only caller of notmuch-search that supplies a thread-id so this +> change should be safe (but could theoretically break users .emacs +> functions). +> --- +> +> I think this implements all of Austin's suggestions, and it adds a short +> remark to NEWS (since in unlikely cases it could break users' functions) +> and updates the docstring for notmuch-search. + +LGTM. -- 2.26.2