From 5edc846c6e8e513496a729d8c5d9e084b1ae7c34 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 10 Oct 2013 13:21:37 +0300 Subject: [PATCH] Re: [PATCH 0/2] emacs: show: use interactive instead of current-prefix-arg --- 79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b | 89 +++++++++++++++++++++++ 1 file changed, 89 insertions(+) create mode 100644 79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b diff --git a/79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b b/79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b new file mode 100644 index 000000000..85bbc88d7 --- /dev/null +++ b/79/b3a3f1b3c2260525c4b53f0b20a55db5d13e4b @@ -0,0 +1,89 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1D194431FAF + for ; Thu, 10 Oct 2013 03:21:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tBTukexWZhrJ for ; + Thu, 10 Oct 2013 03:21:45 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 8AB90431FAE + for ; Thu, 10 Oct 2013 03:21:45 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id E76B8100030; + Thu, 10 Oct 2013 13:21:37 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] emacs: show: use interactive instead of + current-prefix-arg +In-Reply-To: <1381348886-5673-1-git-send-email-markwalters1009@gmail.com> +References: <1381348886-5673-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.16+87~g451fefe (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 10 Oct 2013 10:21:51 -0000 + +On Wed, Oct 09 2013, Mark Walters wrote: + +> This is a tidied up version of the patch at +> id:1380729013-3942-1-git-send-email-markwalters1009@gmail.com +> (incorporating suggestions from Tomi in +> id:m2siwjhapc.fsf@guru.guru-group.fi) +> +> This helps fix a problem in pick but there was reasonable agreement on +> irc that show should not be looking at current-prefix-arg directly. +> +> One test needs to be changed to the new behaviour. + +LGTM. Having elide-toggle &optional looks like a very good idea! + +Tomi + +> +> Best wishes +> +> Mark +> +> +> Mark Walters (2): +> emacs: show: use interactive instead of current-prefix-arg +> test: emacs-show: fix use of prefix-arg +> +> emacs/notmuch-show.el | 12 +++++++----- +> emacs/notmuch.el | 5 +++-- +> test/emacs-show | 3 +-- +> 3 files changed, 11 insertions(+), 9 deletions(-) +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2