From 5d21dbfb4f45a078ac7d08b777809c0a477e563c Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Thu, 23 Feb 2012 11:57:50 +1900 Subject: [PATCH] Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and message-cite-original --- 4e/8c89a0643f311a3315bc5f95dfc92ce935bd11 | 147 ++++++++++++++++++++++ 1 file changed, 147 insertions(+) create mode 100644 4e/8c89a0643f311a3315bc5f95dfc92ce935bd11 diff --git a/4e/8c89a0643f311a3315bc5f95dfc92ce935bd11 b/4e/8c89a0643f311a3315bc5f95dfc92ce935bd11 new file mode 100644 index 000000000..c620005df --- /dev/null +++ b/4e/8c89a0643f311a3315bc5f95dfc92ce935bd11 @@ -0,0 +1,147 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BDD85431FB6 + for ; Wed, 22 Feb 2012 08:57:57 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id woBFToks-w+u for ; + Wed, 22 Feb 2012 08:57:54 -0800 (PST) +Received: from dmz-mailsec-scanner-1.mit.edu (DMZ-MAILSEC-SCANNER-1.MIT.EDU + [18.9.25.12]) + by olra.theworths.org (Postfix) with ESMTP id E86C6431FAE + for ; Wed, 22 Feb 2012 08:57:53 -0800 (PST) +X-AuditID: 1209190c-b7fad6d000000920-e2-4f451e91a5b0 +Received: from mailhub-auth-1.mit.edu ( [18.9.21.35]) + by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP + id C4.E1.02336.19E154F4; Wed, 22 Feb 2012 11:57:53 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q1MGvquv012300; + Wed, 22 Feb 2012 11:57:53 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1MGvoue012234 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Wed, 22 Feb 2012 11:57:52 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1S0FVm-0004xX-6g; Wed, 22 Feb 2012 11:57:50 -0500 +Date: Wed, 22 Feb 2012 11:57:50 -0500 +From: Austin Clements +To: Adam Wolfe Gordon +Subject: Re: [PATCH v5.2 7/7] emacs: Use the new JSON reply format and + message-cite-original +Message-ID: <20120222165750.GC30513@mit.edu> +References: <1329361957-28493-1-git-send-email-awg+notmuch@xvx.ca> + <1329361957-28493-8-git-send-email-awg+notmuch@xvx.ca> + <20120221055920.GA30513@mit.edu> + +MIME-Version: 1.0 +Content-Type: text/plain; charset=iso-8859-1 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +In-Reply-To: + +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsUixCmqrDtRztXf4NQCcYsje2axW1y/OZPZ + gcnj2apbzB5NPxazBjBFcdmkpOZklqUW6dslcGXs2fCbtWCVdMXy18vZGhgbxLoYOTgkBEwk + Vrxy7WLkBDLFJC7cW8/WxcjFISSwj1Gif+olFghnA6NEz4keRgjnJJPE4+s3WCGcJYwSy7bt + YwPpZxFQlbg0YREjiM0moCGxbf9yMFtEQEvix/qvrCA2s4C0xLffzUwgtrBAnMS371fYQc7g + FdCRWH7THmLmU0aJh19mM4PU8AoISpyc+YQFoldHYufWO2wg9SBzlv/jgAjLSzRvhSjnFAiU + mPp/Ddg5ogIqElNObmObwCg8C8mkWUgmzUKYNAvJpAWMLKsYZVNyq3RzEzNzilOTdYuTE/Py + Uot0DfVyM0v0UlNKNzGC40CSZwfjm4NKhxgFOBiVeHgXsbv6C7EmlhVX5h5ilORgUhLlFQFG + kRBfUn5KZUZicUZ8UWlOavEhRgkOZiUR3vZTLv5CvCmJlVWpRfkwKWkOFiVxXhWtd35CAumJ + JanZqakFqUUwWRkODiUJ3ueyQEMFi1LTUyvSMnNKENJMHJwgw3mAhnOALOYtLkjMLc5Mh8if + YlSUEuf9BNIsAJLIKM2D64WlqVeM4kCvCPMeAqniAaY4uO5XQIOZgAa3/HcEGVySiJCSamBM + UzozddPK4C8csUqTvC44erk+lfUPljvZENyecG7Z0jOc09lmTLL5W7naQ9npkXmMaIyuX+/U + t+cUcjmP6cpPvcZokPd818ubcn+cd+UWbpNeu/vc3j+erzcy17Fe5qt3287Fxzb3/ZNI5m18 + 07cWH2n/++rZ5f6ppYlbegOC7QS4GLiyw4WVWIozEg21mIuKEwELFylJLgMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 22 Feb 2012 16:57:57 -0000 + +Quoth Adam Wolfe Gordon on Feb 21 at 9:49 am: +> On Mon, Feb 20, 2012 at 22:59, Austin Clements wrote: +> > I've been thinking about this more.  message-mode's default citation +> > line is really unfortunate and quite possibly insane ("writes" isn't +> > even the right tense and what's up with that extra line break?).  The +> > option to change this is also well hidden (as an experiment, I tried +> > navigating to it through customize and couldn't figure out where it +> > was, even though I knew what I was looking for).  In general, I'm a +> > fan of inheriting as many options from Emacs as possible, but people +> > *are* going to ask how to change this and the default setting *is* +> > going to turn people off of notmuch ("What mail client do you use that +> > generates those quirky citation lines?"  "I use notmuch!"  "Is that, +> > like, from the 80's?"). +> +> Agreed. It's a really unfortunate default. +> +> > So, what about adding a notmuch customize option for selecting the +> > citation line format?  It could offer a few const choices, including a +> > default, sane format, plus the option to enter your own or to fall +> > back to whatever message-mode is configured to do.  If we do this, +> > it's probably best done in a follow-up series, but this seemed like an +> > appropriate place to bring it up. +> +> I think there are two options, which have been discussed a bit before [1]: + +Ah, interesting. I hadn't been following this series at that point. + +> 1) Wrap the citation format with a notmuch customization variable, +> notmuch-citation-line-format or somesuch. Then set the +> message-citation-line-format before calling message-cite-original. +> +> 2) Have notmuch load a user config file (~/.notmuch.el or something) +> on startup, and provide a default file that sets nice defaults for +> things like message-citation-line-format. The default file could even +> be constructed on first run, such that if the user has already +> customized some things (like message-citation-line-format) we can keep +> their settings. +> +> Option 2 is obviously more work, but I think it's the right way to go, +> at least in the long run. In addition to giving a place to provide +> nice defaults for non-notmuch variables, it gives the user a nice +> place to specify notmuch-specific config. For example, I use +> completely separate init files for notmuch and other emacs usage, and +> having a notmuch config file would let me get away from this slightly +> kludgey setup. + +That is an intriguing idea. My main concern would be +forwards-compatibility. When we find some other variable that we want +to add to this file, what do we do with already-generated +.notmuch.els? + +I wouldn't dismiss option 1, though. From a user's perspective, it is +visible that they're using message-mode to edit message drafts and +hence natural that they would customize message-mode to control +editing behavior, but they create a reply by pressing 'r' in a +*notmuch* buffer, which naturally associates the operation with +notmuch, not message-mode. I would go so far as to say reply's use of +message-mode is an implementation detail. Hence, I would never expect +an uninformed user to guess that they have to go to message-mode to +customize the citation format. + +> In either case, this can probably come as a separate patch series, but +> it is good to start discussing it here. +> +> [1] id:"m2mx9i3onw.fsf@wal122.wireless-pennnet.upenn.edu" -- 2.26.2