From 5afb5ab6eb65455b36ad7c05c78e86ec0c53c30d Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 5 Feb 2012 12:50:49 +0000 Subject: [PATCH] Re: [Patch v2 0/4] Control selection of From: header when replying --- 1f/1f220cfec3ceee5882bdfc578c90c51ebc0cff | 115 ++++++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 1f/1f220cfec3ceee5882bdfc578c90c51ebc0cff diff --git a/1f/1f220cfec3ceee5882bdfc578c90c51ebc0cff b/1f/1f220cfec3ceee5882bdfc578c90c51ebc0cff new file mode 100644 index 000000000..756d0c1de --- /dev/null +++ b/1f/1f220cfec3ceee5882bdfc578c90c51ebc0cff @@ -0,0 +1,115 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BA73C431FAF + for ; Sun, 5 Feb 2012 04:49:41 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id tbCbtCxh5QSe for ; + Sun, 5 Feb 2012 04:49:41 -0800 (PST) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0964B431FAE + for ; Sun, 5 Feb 2012 04:49:41 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Ru1XH-0002Zx-CD; Sun, 05 Feb 2012 12:49:39 +0000 +Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] + helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) + (envelope-from ) + id 1Ru1XH-0002Ac-31; Sun, 05 Feb 2012 12:49:39 +0000 +From: Mark Walters +To: Dmitry Kurochkin , notmuch@notmuchmail.org +Subject: Re: [Patch v2 0/4] Control selection of From: header when replying +In-Reply-To: <87ipjlix6r.fsf@gmail.com> +References: <1328388317-20161-1-git-send-email-markwalters1009@gmail.com> + <87ipjlix6r.fsf@gmail.com> +User-Agent: Notmuch/0.11+154~ged6d37e (http://notmuchmail.org) Emacs/23.2.1 + (i486-pc-linux-gnu) +Date: Sun, 05 Feb 2012 12:50:49 +0000 +Message-ID: <87y5shv3yu.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.192.233.223 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: b180ffd8aa6828dd892f2d912cc73a41 (of first 20000 bytes) +X-SpamAssassin-Score: -1.8 +X-SpamAssassin-SpamBar: - +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -1.8 points. + Summary of the scoring: + * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, + * medium trust + * [138.37.6.40 listed in list.dnswl.org] + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay + * domain + * 0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Feb 2012 12:49:41 -0000 + +On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin wrote: +> Hi Mark. +> +> I am not sure I like this solution. My concerns are: +> +> * New option looks too complex, too specific. +> +> * There are more aspects of notmuch reply behavior which users would +> like to change (e.g. which part to quote). If we add an option for +> each, we complicate both nomtuch show UI and code. +> +> The problem is that notmuch show output format is too limiting. Instead +> of providing myriad of options for tweaking notmuch show text format +> behavior, we should add JSON format for notmuch reply similar to nomtuch +> show. That would allow notmuch reply to produce structured output with +> required additional information, which should be enough for users to +> construct whatever reply they want. +> +> In this particular case, notmuch reply JSON format could have +> "from-source" attribute that would indicate how it was guessed. +> +> Now the best part. Not so long ago, Adam (in Cc) provided a patch for +> improving nomtuch reply for HTML-only emails. At first he added an +> option for notmuch reply, like you did for from-guessing. I suggested +> him to implement it based on the JSON format instead and he did. AFAIK +> the latest version of his patches is [1]. I did not look at the code +> though. It seems that it is waiting for more review. +> +> So, instead of adding more nomtuch show options, I think a better +> solution is to work with Adam to get the notmuch reply JSON format to +> master and then fix the from-guessing issue by adding an attribute to +> notmuch reply JSON format. + +Yes I think you are quite right: this would be a better solution +(particularly as Adam has already done all the hard work!) + +Many thanks + +Mark -- 2.26.2