From 58f8d634530718d82f9217ecf392ac221bb41efa Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 9 Mar 2012 12:50:03 +0200
Subject: [PATCH] Re: [PATCH] mime_node_open: check if the file is in mbox
 format, and inform gmime.

---
 09/95beb0e48df25e08da8c713fa0d242fff09c72 | 73 +++++++++++++++++++++++
 1 file changed, 73 insertions(+)
 create mode 100644 09/95beb0e48df25e08da8c713fa0d242fff09c72

diff --git a/09/95beb0e48df25e08da8c713fa0d242fff09c72 b/09/95beb0e48df25e08da8c713fa0d242fff09c72
new file mode 100644
index 000000000..fc40dc143
--- /dev/null
+++ b/09/95beb0e48df25e08da8c713fa0d242fff09c72
@@ -0,0 +1,73 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 8B279431FB6
+	for <notmuch@notmuchmail.org>; Fri,  9 Mar 2012 02:50:06 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id j4snxUMJg2iD for <notmuch@notmuchmail.org>;
+	Fri,  9 Mar 2012 02:50:05 -0800 (PST)
+Received: from guru.guru-group.fi (guru-group.fi [87.108.86.66])
+	by olra.theworths.org (Postfix) with ESMTP id 5B8E5431FAE
+	for <notmuch@notmuchmail.org>; Fri,  9 Mar 2012 02:50:05 -0800 (PST)
+Received: by guru.guru-group.fi (Postfix, from userid 501)
+	id 3748168055; Fri,  9 Mar 2012 12:50:03 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] mime_node_open: check if the file is in mbox format,
+	and inform gmime.
+In-Reply-To: <1331243295-27324-1-git-send-email-david@tethera.net>
+References: <87vcme3kf6.fsf@pip.fifthhorseman.net>
+	<1331243295-27324-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.11.1+288~g4b3af0e (http://notmuchmail.org) Emacs/23.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 09 Mar 2012 12:50:03 +0200
+Message-ID: <m2aa3qjbfo.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain; charset=us-ascii
+Cc: David Bremner <bremner@debian.org>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 09 Mar 2012 10:50:06 -0000
+
+On Thu,  8 Mar 2012 17:48:15 -0400, David Bremner <david@tethera.net> wrote:
+> From: David Bremner <bremner@debian.org>
+> 
+> It seems that it has always been an error to try to parse an mbox
+> format file with gmime without calling g_mime_parser_set_scan_from.
+
+At least for the time being I think we should apply
+http://en.wikipedia.org/wiki/Robustness_principle to this case
+and accept email files that start with 'From '...
+
+> This change reads the first 5 bytes of the file, and if they are "From ",
+> declares the file to be an mbox.
+
+an alternative to this is not to declare file as an mbox one but
+if first line starts with 'From ' skip that line.
+
+Whether this is a good idea or not I've already thought an implementation
+how to do this which I'll post as an RFC patch in next 12 hours.
+
+
+Tomi
-- 
2.26.2