From 56ff418764db15d50e883db0172ffd5f472f8602 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Tue, 7 Feb 2012 09:14:39 +1900 Subject: [PATCH] Re: [PATCH 1/2] cli: convert "notmuch show" to use the new argument parser --- 7b/bc4c07185a83261dd2dfe47e9f691f53298633 | 101 ++++++++++++++++++++++ 1 file changed, 101 insertions(+) create mode 100644 7b/bc4c07185a83261dd2dfe47e9f691f53298633 diff --git a/7b/bc4c07185a83261dd2dfe47e9f691f53298633 b/7b/bc4c07185a83261dd2dfe47e9f691f53298633 new file mode 100644 index 000000000..b459c1b0b --- /dev/null +++ b/7b/bc4c07185a83261dd2dfe47e9f691f53298633 @@ -0,0 +1,101 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3589F431FAF + for ; Mon, 6 Feb 2012 06:15:58 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5mPj3XL-ZhzY for ; + Mon, 6 Feb 2012 06:15:57 -0800 (PST) +Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU + [18.7.68.34]) + by olra.theworths.org (Postfix) with ESMTP id 82B8E431FAE + for ; Mon, 6 Feb 2012 06:15:57 -0800 (PST) +X-AuditID: 12074422-b7fd66d0000008f9-4f-4f2fe09adbbb +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP + id 99.88.02297.A90EF2F4; Mon, 6 Feb 2012 09:15:54 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q16EFrZi010758; + Mon, 6 Feb 2012 09:15:54 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q16EFonX022585 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Mon, 6 Feb 2012 09:15:53 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1RuPL5-0006ur-Q4; Mon, 06 Feb 2012 09:14:39 -0500 +Date: Mon, 6 Feb 2012 09:14:39 -0500 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH 1/2] cli: convert "notmuch show" to use the new argument + parser +Message-ID: <20120206141439.GR10898@mit.edu> +References: + + <20120206041205.GP10898@mit.edu> <87ty34bdnp.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87ty34bdnp.fsf@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsUixG6nojvrgb6/wcw3uhZN050trt+cyezA + 5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZey684K94Bh7xekp55kbGF+zdjFyckgImEi8 + a3/ICGGLSVy4t54NxBYS2Mco0dcnC2GvZ5To7+CEsE8wSXS3+XcxcgHZSxglbvydAzSIg4NF + QEVi1QNRkBo2AQ2JbfuXg80UEVCU2HxyP5jNLCAt8e13MxOILSwQKvF31UR2EJtXQEdi9o0G + Voj50xglvu6QhIgLSpyc+YQFoldL4sa/l0wgq0DmLP/HAWJyAq26t0kBpEIU6IApJ7exTWAU + moWkeRaS5lkIzQsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmurlZpbopaaUbmIEB7OL0g7G + nweVDjEKcDAq8fAqmuj7C7EmlhVX5h5ilORgUhLl5QPGghBfUn5KZUZicUZ8UWlOavEhRgkO + ZiURXrVJQDnelMTKqtSifJiUNAeLkjivutY7PyGB9MSS1OzU1ILUIpisDAeHkgSvHMhQwaLU + 9NSKtMycEoQ0EwcnyHAeoOGSIDW8xQWJucWZ6RD5U4yKUuK83+8DJQRAEhmleXC9sGTzilEc + 6BVh3o8gVTzARAXX/QpoMBPQ4H1suiCDSxIRUlINjEJuR7+K9ixjKTTY1flwVT5zqKRgheT9 + CZvvXfP5teaAgbWZ84MVXA9sU703uzR8S7p4RfTsRcMLPYE/TCrSdR8YfXfk5P93clVp4erS + d3tPKu1/U1EmeE37vyPXN52kcPm0bedaTZbt+9vkenqPyu7F7z4+fmI+y0N6w+FYo7anq3uf + pR6UvarEUpyRaKjFXFScCADwROTxEQMAAA== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 06 Feb 2012 14:15:58 -0000 + +Quoth Jani Nikula on Feb 06 at 7:54 am: +> On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements wrote: +> > Yikes. I don't envy you this patch. Two minor nits, otherwise this +> > and the next patch LGTM. +> +> Thanks for the review. I'll roll another version, I think it will be +> better with your suggestions incorporated. +> +> > Quoth Jani Nikula on Feb 04 at 12:41 am: +> > > Use the new notmuch argument parser to handle arguments in "notmuch +> > > show". There are two corner case functional changes: +> > > +> > > 1) Also set params.raw = 1 when defaulting to raw format when part is +> > > requested but format is not specified. +> > +> > Huh. So "notmuch show --part=0 " was broken before. +> +> Hmm, yes, it seems so. Do you think I should make this a separate fix? + +I wouldn't bother. Since this usage would throw --format=raw into +"useless mode", clearly no one cared. No sense throwing good code +after bad. -- 2.26.2