From 5671272007b5a9cef76ac47eb01092bb3c4248b4 Mon Sep 17 00:00:00 2001 From: Jameson Graef Rollins Date: Thu, 24 May 2012 10:34:53 +1700 Subject: [PATCH] Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts and parameters, and functions to support it --- 73/a938dfcfcf01adad362a1c1aeb5b5e843807b7 | 108 ++++++++++++++++++++++ 1 file changed, 108 insertions(+) create mode 100644 73/a938dfcfcf01adad362a1c1aeb5b5e843807b7 diff --git a/73/a938dfcfcf01adad362a1c1aeb5b5e843807b7 b/73/a938dfcfcf01adad362a1c1aeb5b5e843807b7 new file mode 100644 index 000000000..16e4688f8 --- /dev/null +++ b/73/a938dfcfcf01adad362a1c1aeb5b5e843807b7 @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3E40A431FBD + for ; Wed, 23 May 2012 10:35:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.29 +X-Spam-Level: +X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id QGZwY4vMHpm6 for ; + Wed, 23 May 2012 10:35:02 -0700 (PDT) +Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu + [131.215.239.19]) + by olra.theworths.org (Postfix) with ESMTP id 0DDD2431FAF + for ; Wed, 23 May 2012 10:35:02 -0700 (PDT) +Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) + by fire-doxen-postvirus (Postfix) with ESMTP id 747982E50936; + Wed, 23 May 2012 10:34:59 -0700 (PDT) +X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new +Received: from finestructure.net (unknown [137.151.175.56]) + (Authenticated sender: jrollins) + by fire-doxen-submit (Postfix) with ESMTP id ABC812E50B79; + Wed, 23 May 2012 10:34:56 -0700 (PDT) +Received: by finestructure.net (Postfix, from userid 1000) + id 6ECDC1E1; Wed, 23 May 2012 10:34:56 -0700 (PDT) +From: Jameson Graef Rollins +To: Jani Nikula +Subject: Re: [PATCH v3 1/6] cli: new crypto structure to store crypto contexts + and parameters, and functions to support it +In-Reply-To: + +References: <1337737430-21160-1-git-send-email-jrollins@finestructure.net> + <1337737430-21160-2-git-send-email-jrollins@finestructure.net> + +User-Agent: Notmuch/0.13+24~g16915cd (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 23 May 2012 10:34:53 -0700 +Message-ID: <87396q7qde.fsf@servo.finestructure.net> +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha256; protocol="application/pgp-signature" +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 23 May 2012 17:35:04 -0000 + +--=-=-= + +On Tue, May 22 2012, Jani Nikula wrote: +>> +/* for the specified protocol return the context pointer (initializing +>> + * if needed) */ +>> +GMimeCryptoContext * +>> +notmuch_crypto_get_context (notmuch_crypto_t *crypto, const char +> *protocol) +>> +{ +>> + GMimeCryptoContext *cryptoctx = NULL; +> +> Isn't GMimeCryptoContext gmime 2.6 specific? It's #ifdeffed elsewhere at +> least. Also affects the return type. + +Yes, good catch, Jani. Thank you. Will fix. + +>> + if ((strcmp (protocol, "application/pgp-signature") == 0) +>> + || (strcmp (protocol, "application/pgp-encrypted") == 0)) { +> +> Is protocol guaranteed to be lower case? + +That's a good question. I don't know. I'll check and fix +appropriately. + +jamie. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.12 (GNU/Linux) + +iQIcBAEBCAAGBQJPvR++AAoJEO00zqvie6q8LwcP/1Dkf1kIHTcow27JWLSMd/D5 +Zpr/cRXNOPcmvNyeD8h9UeWAYfDoslYpH952q4k5qkX+UzGk1WzjDhVCaJc+qPk4 +G2eA6boKdJ+FxilFJejjPeeFULvuVjNnnaM/ZuLTgTr0aOBRalcgCFNFOyx0yoTg +/sYtDR6bt/s8hsibnpMHlrYU0u9iy4Mfn9AEPjWnGeMnM3J7RsJVlR1tp0Q1z61o +jNyPaHbdz+VZCjQjV171Cony7Ggx1eyzFeGFS38jKhtix6JUeAm/AaYv/tBvCs0h +17Dmp9gAyuYHg34UA9nPGbZaBxt8Pbtilggg9bYXEv8f45sPGzbZ3mncCEqKfFVW +8Xf1E0hINlo0mlyU7f1EW3O1nrfn9nOxwl728yP6eGumf12BN1b6mfrWygDTkOsj +rqV/eR2pFVQ2RPmkTCqQ6THLELh3iLAdAdveGvl6KyM7H3XrH+KcuTKhQ1No6Asu +ar7+4lU9ejOsn3AvgjAC/xvkO4PC5zFGXDi1O+iMXnkt71gem870aYZ+ZKiCTmO3 +x7wbnlyGgeH3P7FSTbLsdOwrLR2bxZwP3JPGZRatXL2K/s9MqnJEVzU5S57SfDJm +orcblUQsvmpXCssEFcO5dm+5CcnsEzutZMVJoPRwReXvZhvWjVhrui0Gv+2N2oWt +u/krc6Y10TW8N+WxYJbQ +=Be01 +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2