From 544e3a5978aa664afe242f5ab5dd3305cfed6322 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Thu, 15 Nov 2012 16:42:12 +0100 Subject: [PATCH] Re: [PATCH v2] emacs: display tags in notmuch-show with links --- 52/33252748a30aa14f75d04029934685bb292ac1 | 135 ++++++++++++++++++++++ 1 file changed, 135 insertions(+) create mode 100644 52/33252748a30aa14f75d04029934685bb292ac1 diff --git a/52/33252748a30aa14f75d04029934685bb292ac1 b/52/33252748a30aa14f75d04029934685bb292ac1 new file mode 100644 index 000000000..e571a4a9a --- /dev/null +++ b/52/33252748a30aa14f75d04029934685bb292ac1 @@ -0,0 +1,135 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id ADA82431FAF + for ; Thu, 15 Nov 2012 07:42:34 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id GLiFa0-qqp3I for ; + Thu, 15 Nov 2012 07:42:34 -0800 (PST) +Received: from mail-vb0-f53.google.com (mail-vb0-f53.google.com + [209.85.212.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id E524C431FAE + for ; Thu, 15 Nov 2012 07:42:33 -0800 (PST) +Received: by mail-vb0-f53.google.com with SMTP id fc21so1826201vbb.26 + for ; Thu, 15 Nov 2012 07:42:33 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:from:date:message-id:subject:to + :cc:content-type; + bh=DjDqk7F5POo5ilBBApsbgS2kvJKhS2NfWRJWAloC8kQ=; + b=dcb4Ki8E3Lm04v8zvqnGFFjgnhQZKCTf77eNEwlKbSRFBXJXKfewEAWweZ6Ct2ICek + IFTq0l01n4H65ILhQwgpYah1qqsP/hFpYwoQNghGvDQsO+D54iZkdeMdD6QhZgL23fK1 + POJ4jDEQ0d4cg3/6IGAVf501QeqEn6pHegh6Da+dPCqheHHE7Hz35He6NsVw0IwyeXov + zQzoqNDzzhdt/pkGD1dGFkZRJnnJowymzf06TZKaqg7hFMTVzK/1HIFTy+Wlk4ZBOaCW + A2V8ggLwLuVbk1RSbbgJOsPs7IvML39YnD3JbpeJFPfNlgKfK+LwSZh8TiiRXi4CBvy4 + HGcQ== +Received: by 10.220.227.70 with SMTP id iz6mr1890952vcb.45.1352994153264; Thu, + 15 Nov 2012 07:42:33 -0800 (PST) +MIME-Version: 1.0 +Received: by 10.58.143.51 with HTTP; Thu, 15 Nov 2012 07:42:12 -0800 (PST) +In-Reply-To: <878va4xson.fsf@qmul.ac.uk> +References: <1352565719-12397-1-git-send-email-damien.cassou@gmail.com> + <878va4xson.fsf@qmul.ac.uk> +From: Damien Cassou +Date: Thu, 15 Nov 2012 16:42:12 +0100 +Message-ID: + +Subject: Re: [PATCH v2] emacs: display tags in notmuch-show with links +To: Mark Walters +Content-Type: text/plain; charset=ISO-8859-1 +Cc: notmuch mailing list +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 15 Nov 2012 15:42:34 -0000 + +On Wed, Nov 14, 2012 at 1:41 PM, Mark Walters wrote: +> On the loading library issues I defer to Adam and Tomi. + + +I think they are right and I will try to make my code do something +good by default and do something better if header-button is detected. + + +> I do have a couple of comments on the current version +> though. First the patch is very big. I would prefer it split into +> several pieces + + +do you want me to send totally separate emails or do you want me to +send 1 discussion of multiple emails (with 0/4, 1/4, 2/4,...) ? + + +> something like: +> +> 1) Add tags to the headerline but not clickable + + +makes perfect sense + + +> 2) Add the header-button library if appropriate + + +I will try the other approach of not embedding the library in notmuch + + +> 3) Add notmuch-tagger and change headerline to buttonize the tags + + +makes perfect sense. The patch will buttonize the links if +header-button is present and nothing otherwise. + + +> 4) Add the tests. + +ok + + ++ 5) Add buttons to tags in the body + + +>> +(defun notmuch-tagger-present-tags (tags &optional headerline) +>> + "Return a property list which nicely presents all TAGS. +>> + +>> +If HEADERLINE is non-nil the returned list will be ready for +>> +inclusion in the buffer's header-line. HEADERLINE must be nil in +>> +all other cases." +> +> I find it odd to say what it returns if HEADERLINE is non-nil and then +> say otherwise HEADERLINE must be nil. Could you say what it returns in +> the nil case? Something along them lines of +> +> "if HEADERLINE is non-nil the returned will be ready for inclusion in +> the buffer's header-line (i.e., will use header-buttons if +> available). Otherwise it returns a list?? ready for inclusion in a +> buffer." + +thank you for the comment, I will fix it and propose new patches + + +-- +Damien Cassou +http://damiencassou.seasidehosting.st + +"Success is the ability to go from one failure to another without +losing enthusiasm." +Winston Churchill -- 2.26.2