From 52c2da6c17d8e00e200f894f7ca3c7053bf05fca Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 2 Dec 2012 16:47:16 +0200 Subject: [PATCH] Re: V2 of batch-tagging plus new dump/restore --- c7/b4befd13b1104943513d2694af6664b987f684 | 124 ++++++++++++++++++++++ 1 file changed, 124 insertions(+) create mode 100644 c7/b4befd13b1104943513d2694af6664b987f684 diff --git a/c7/b4befd13b1104943513d2694af6664b987f684 b/c7/b4befd13b1104943513d2694af6664b987f684 new file mode 100644 index 000000000..f0bcee9c1 --- /dev/null +++ b/c7/b4befd13b1104943513d2694af6664b987f684 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 2B6AD431FAF + for ; Sun, 2 Dec 2012 06:47:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5G3ETPjWz6z7 for ; + Sun, 2 Dec 2012 06:47:21 -0800 (PST) +Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com + [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 76DF4431FAE + for ; Sun, 2 Dec 2012 06:47:21 -0800 (PST) +Received: by mail-lb0-f181.google.com with SMTP id ge1so1792623lbb.26 + for ; Sun, 02 Dec 2012 06:47:20 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=google.com; s=20120113; + h=from:to:subject:in-reply-to:references:user-agent:date:message-id + :mime-version:content-type:x-gm-message-state; + bh=w95pW4lesVOiMnQbtOaYbBia5XNZ/gajsqNgV/Xdf74=; + b=mznj0jkaNEB8MQh903n/9sIQfrHtekld2VucdGg4/m+Jd9tTXc0KCzO3Cs5s45yYjU + kJV+R0RllTxgHIRU9c3wSM1W0JuyTOnMdUTAdjno3KpTnl76Xi8qVnBbtlECc57gyPMc + PMelQSQbau1ABF5NM0IsqQB3gZ2Ti4TaEec4feVweYUYWwzDEvXkQqQGtXunKVWmqlqz + g5mNg6+uVRR47S0wHGNZelqDvaAPpBg+q2Frfx/39vfD9Beqn/pP/p2yznkPxP1ePXFR + 6ayTokCV0UV4X2vtNjRgw7y2BYEVcb8qWFbQoh0TjWfRy2O5pQWy6Fo78nBPjB4YGDbL + 6s7A== +Received: by 10.152.108.197 with SMTP id hm5mr6769487lab.45.1354459639951; + Sun, 02 Dec 2012 06:47:19 -0800 (PST) +Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi. + [80.223.81.27]) + by mx.google.com with ESMTPS id gt17sm4099896lab.6.2012.12.02.06.47.18 + (version=SSLv3 cipher=OTHER); Sun, 02 Dec 2012 06:47:19 -0800 (PST) +From: Jani Nikula +To: david@tethera.net, notmuch@notmuchmail.org +Subject: Re: V2 of batch-tagging plus new dump/restore +In-Reply-To: <1353792017-31459-1-git-send-email-david@tethera.net> +References: <1353792017-31459-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.14+124~g3b17402 (http://notmuchmail.org) Emacs/23.4.1 + (i686-pc-linux-gnu) +Date: Sun, 02 Dec 2012 16:47:16 +0200 +Message-ID: <87r4n8cxzf.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Gm-Message-State: + ALoCoQk0JL5a8LFMHTKbtj9d/AXROLOdoH3bnXeoc4kG1GICqEfBP6QIPV894VsQlKXP7LU5+6fJ +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Dec 2012 14:47:26 -0000 + + +Hi David - + +Good job! And thanks for resurrecting batch tagging. + +Apart from a few actual bugs and a bag of nitpicks, I think this looks +very good overall. And I don't think any of the issues are very +difficult to fix (some of the nitpicks you can just outright ignore; use +your discretion). We should definitely get this done for the next +release. + +BR, +Jani. + + +On Sat, 24 Nov 2012, david@tethera.net wrote: +> this obsoletes: id:1353265498-3839-1-git-send-email-david@tethera.net +> +> Changes based on Mark's review +> +> - add commments for each function in tag-util.h +> +> - inline tag_op_list_from_string in the one place it was called +> +> - remove NULL terminator from tag_op_list (for mark); along with +> tag_op_list_t being opaque, I thought is was ok to leave off the +> comment on ops. But I could be convinced. +> +> - make tag_op_list_t typedef opaque +> +> - add BE_GENEROUS flag to parser. Currently this enables empty tags. +> +> - handle blank lines and comments in restore and batch tagging +> +> - fixed the commit message about "notmuch-new" +> +> Changes based on Ethan's review: +> +> - remove the dreaded . from first line of commit messages +> +> - convert if on l49 of database-test.c into explicit return on error +> +> - add comments and parens for num_tags and this_mid_len in random_corpus.c +> +> - add check for message-id's less than length 1. I wasn't sure why we +> would disallow all message ids of length 1. +> +> - remove declaration of parse_tag_stream +> +> - explain "query_string += 3" +> +> - fix typo in notmuch-dump.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2