From 51ba2ce8b34cdef7e01df2ea53402aeef169ca44 Mon Sep 17 00:00:00 2001 From: Michal Sojka Date: Wed, 23 May 2012 12:20:21 +0200 Subject: [PATCH] Re: [PATCH] emacs: use 'gnus-decoded in notmuch-mm-display-part-inline () --- 94/40ec3e9df739582a12ad449ffabe71801c2bff | 100 ++++++++++++++++++++++ 1 file changed, 100 insertions(+) create mode 100644 94/40ec3e9df739582a12ad449ffabe71801c2bff diff --git a/94/40ec3e9df739582a12ad449ffabe71801c2bff b/94/40ec3e9df739582a12ad449ffabe71801c2bff new file mode 100644 index 000000000..d633036b3 --- /dev/null +++ b/94/40ec3e9df739582a12ad449ffabe71801c2bff @@ -0,0 +1,100 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B9B74431FBD + for ; Wed, 23 May 2012 03:20:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.656 +X-Spam-Level: +X-Spam-Status: No, score=-1.656 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3, URIBL_SBL=0.644] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5EbXbjB9NJ7V for ; + Wed, 23 May 2012 03:20:28 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id E7B3C431FAF + for ; Wed, 23 May 2012 03:20:27 -0700 (PDT) +Received: from localhost (unknown [192.168.200.4]) + by max.feld.cvut.cz (Postfix) with ESMTP id 5060719F3353; + Wed, 23 May 2012 12:20:26 +0200 (CEST) +X-Virus-Scanned: IMAP AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, + port 10044) + with ESMTP id lAzNF8Xelbgq; Wed, 23 May 2012 12:20:21 +0200 (CEST) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 916FF3CFE74; + Wed, 23 May 2012 12:20:21 +0200 (CEST) +Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) + (Authenticated sender: sojkam1) + by imap.feld.cvut.cz (Postfix) with ESMTPSA id 871E6660968; + Wed, 23 May 2012 12:20:21 +0200 (CEST) +Received: from wsh by steelpick.2x.cz with local (Exim 4.77) + (envelope-from ) + id 1SX8g1-0004yN-Ft; Wed, 23 May 2012 12:20:21 +0200 +From: Michal Sojka +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: use 'gnus-decoded in + notmuch-mm-display-part-inline () +In-Reply-To: <1337533094-5467-1-git-send-email-tomi.ollila@iki.fi> +References: <1337533094-5467-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.13+14~g2d2a5a4 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 23 May 2012 12:20:21 +0200 +Message-ID: <87obpfurkq.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Cc: Tomi Ollila +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 23 May 2012 10:20:28 -0000 + +Tomi Ollila writes: +> When mail message is read from emacs, the message structure +> obtained may contain parts which have content included +> (`text/plain` for example) and other parts where content is not +> included (`text/html` for example). +> +> In case content is included, the string is already available in +> emacs' internal format and therefore mm-... functions should not +> attempt to do further decoding for the data in temp buffer +> provided for it. +> +> Currently when reply buffer is created, +> notmuch-mm-display-part-inline () is used to provided quoted reply +> content. This change makes the mm-... functions called by it use +> 'gnus-decoded as charset whenever the content is already available. +> +> File .../emacs-23.3/lisp/gnus/mm-uu.el mentions: +> "`gnus-decoded' is a fake charset, which means no further decoding." +> --- +> +> I propose this patch is taken into 0.13.1. + +LGTM. I use it in my private branch. The bug fixed by this patch is +really annoying. + +> +> Please note that I'm not entirely sure my description above +> is right. So those who knows more of these issues please check +> my "facts". + +Your description matches with what I found in +id:"871umc1int.fsf@steelpick.2x.cz". + + +Thanks, +-Michal -- 2.26.2